Google Git
Sign in
chromium / chromium / src / be28fe26931bdea248ce47dd1500397b76c4ebf3
commitbe28fe26931bdea248ce47dd1500397b76c4ebf3[log] [tgz]
authorAdithya Srinivasan <adithyas@chromium.org>Fri Mar 22 21:04:15 2019
committerCommit Bot <commit-bot@chromium.org>Fri Mar 22 21:04:15 2019
tree087549058bc7f7d16b3f2a138e6087960e028fc1
parentd2b6b216eec33310411c81e3891cf496b7e6d3c1 [diff]
Portals: Add checks for failure scenarios for activate()

The promise returned by activate() rejects with an error if:

- activate() is called on a portal that is already activating
- activate() is called on a portal when another portal in the document
  is already activating
- activate() is called on a nested portal

Bug: 914122
Change-Id: I43136bc363be9f710dae6c107058b7b1a6674263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496482
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643545}
11 files changed
tree: 087549058bc7f7d16b3f2a138e6087960e028fc1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .