commit | bed9612a2bf4fc5e1326210526697df1cb8d9b21 | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Thu Aug 01 11:20:34 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 01 11:20:34 2019 |
tree | bb96df0ec84e51e99d1b3712c11216ba53a3e419 | |
parent | bab38f9cc3bf3a6ff13db477bac268e3d6b70ffa [diff] |
Re-allow nullptr animating elements Because of an unintended behavior change in [1], it's no longer possible to have a nullptr animating element, since StyleResolverState:: GetAnimatingElement will fall back to GetElement() if pseudo_element is nullptr. Previously (pre-[1]), if the PseudoElement* retrieved by StyleResolver::PseudoStyleForElement was nullptr, the animating element would just be nullptr, and not fall back to anything. This CL restores that behavior by passing PseudoId to a dedicated StyleResolverState constructor. That way we know whether we're doing a style resolution for a pseudo element or a regular element, and we can return the correct thing from GetAnimatingElement. Also removed the StyleResolverState constructor which accepted a ElementResolveContext, since it only had one call site which anyway did the same thing as the other constructor. [1] https://crrev.com/c/1724680 Bug: 989151,989402,989437 Change-Id: I0aecf0a7a3a857dbd0664d969abeea7ec5852260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729250 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#683124}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .