Google Git
Sign in
chromium / chromium / src / bfa44d228f4f4afc873ee796dbba2c72fc958582
commitbfa44d228f4f4afc873ee796dbba2c72fc958582[log] [tgz]
authorMustafa Emre Acer <meacer@chromium.org>Tue Jan 08 21:13:52 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jan 08 21:13:52 2019
treec6d9494cdfb49ec9e3f3925c323c7fb867629348
parent34d390f23f630f8c5187e096c44b47656bcafde2 [diff]
Lookalike URLs: Exclude registry when doing edit distance comparison

The edit distance heuristic in Lookalike URLs feature records a match
if the navigated domain is one edit distance away from one of the top
500 domains. However, it takes the registry of the domains into account
as well, causing bogus matches.

As an example, it matches google.com.tw to google.com.tr (top domain),
even though the former is unlikely to be a spoofing attempt. This CL
correctly handles this case.

Bug: 913647
Change-Id: Ifa04a3f6eeccd0b97dde364d3cd2ef3d415f6ef1
Reviewed-on: https://chromium-review.googlesource.com/c/1396304
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620877}
7 files changed
tree: c6d9494cdfb49ec9e3f3925c323c7fb867629348
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .