commit | c0e1c0151c5eb1953a873b089d28994f5db07680 | [log] [tgz] |
---|---|---|
author | Nick Diego Yamane <nickdiego@igalia.com> | Tue Dec 10 20:35:07 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 10 20:35:07 2024 |
tree | 9ac6d104f39db776bf646e8252807b1683e20ca1 | |
parent | 6108536b7726d8ed47889f93262b645ba46858ff [diff] |
wayland: tabdrag: ensure abort is handled Wayland compositors may (and usually do) unset keyboard focus during drag-and-drop sessions. User-triggered cancellation is handled through wl_data_source::cancelled event instead. However the interface between ozone/platform_window and chrome's tab drag layers is based on event dispatching. To notify the drag was cancelled, for example, an ESC key event is synthesized and dispatched by platform window code and then handled by TabDragController accordingly. That said, as it isn't possible to guarantee at client-side that there will be a keyboard-focused window by the cancellation time, this CL fixes the linked crbug by ensuring window drag controller's event grabber is temporarily focused when synthesizing the ESC key event, so that it is necessarily handled by chrome's TabDragController. R=orko@igalia.com Fixed: 382108346 Bug: 329479345 Test: Manually with both Gnome Shell 48 (patched with xdg-toplevel-drag) and KWin 6.2.3 Change-Id: I190dd46a836ef02bcb799588645cd5a653e93758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6082759 Reviewed-by: Orko Garai <orko@igalia.com> Reviewed-by: Max Ihlenfeldt <max@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/main@{#1394495}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.