| commit | c0fee27d4307cb92cbe13e4d519f7c11b025a90b | [log] [tgz] |
|---|---|---|
| author | qyearsley <qyearsley@chromium.org> | Thu Jul 21 21:03:54 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Jul 21 21:06:25 2016 |
| tree | 41c1d5598ba7ed2e93ab0c97c56bd7a90b0dbbec | |
| parent | 91c4694ecfdd34810a9f267698c6f236ffefeac5 [diff] |
Reland of actor the buildbot module in webkitpy. (patchset #1 id:1 of https://codereview.chromium.org/2165983003/ ) Reason for revert: Creating a re-land CL to fix the issue encountered in https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281 and then re-land. As of the time when this reland patch is created, I still haven't found the cause of the problem. Original issue's description: > Revert of Refactor the buildbot module in webkitpy. (patchset #3 id:40001 of https://codereview.chromium.org/2152663003/ ) > > Reason for revert: > On 2016/07/20 at 17:51:31, vadimsh wrote: > > Probably broke rebaseline-o-matic: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281 > > Original issue's description: > > Refactor the buildbot module in webkitpy. > > > > This CL refactors BuildBot so that: > > - There is now a results_url method in the BuildBot class (moved from AbstractRebaseliningCommand) > > - Redundant functions are removed > > - The Builder and Build classes are removed > > - Buildbot-related functions in webkitpy.common.config.urls are moved into BuildBot > > - Unit test and mock version are updated > > > > The purpose of this is to simplify the code; this is a follow-up to http://crrev.com/2112133002 which removed some unused functionality. > > > > Committed: https://crrev.com/66b942da80d7af5806f50630e55a9800102f43e1 > > Cr-Commit-Position: refs/heads/master@{#406599} > > TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/b7c2c15eac19863207b008eaaa7916b726ef8d6c > Cr-Commit-Position: refs/heads/master@{#406614} TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2164153002 Cr-Commit-Position: refs/heads/master@{#406933}