More small cleanups in sync_ui_util

- Remove an obsolete HasPrimaryAccount() check.
- Minimize inputs, e.g. GetStatusForAuthError() only needs an auth_error,
  not the whole Profile.
- IsPassphraseRequiredForDecryption() implies IsPassphraseRequired(), so
  no need to check both.
- Add an explicit IsLocalSyncEnabled() check to
  ShouldRequestSyncConfirmation() - we should never ask for confirmation
  for local Sync.

Bug: 911153
Change-Id: I7bacf019e0a929b4d519a00d18fa9987c2f94efd
Reviewed-on: https://chromium-review.googlesource.com/c/1451939
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628764}
1 file changed