commit | c2869e1e867c8adf275fd925a6d40cac049e8134 | [log] [tgz] |
---|---|---|
author | Fabio Tirelo <ftirelo@chromium.org> | Tue Jul 17 18:58:47 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 17 18:58:47 2018 |
tree | d18416f114b29c729cb005c358ace1d2b3412db1 | |
parent | 80f4f2d63947116972d3ce46a36d8882928ddfdc [diff] |
[AF] Cleanup rows when the popup is hidden This fixes a flaky test on ChromeOS, in which a mouse exit event can be received by a row after the popup is hidden (in the test in case, this happened when the frame that contained the dropdown was deleted). The solution here consists of not giving rows direct access to the controller; now they need to use an accessor method in the native view, which will return nullptr after the popup is hidden. As a safety measure, also protected other accesses to the controller, except on CreateContent(), which is called when a row is being created, and the controller's existence is guaranteed. Bug: 864477 Change-Id: I8be9be974065543ca9da6ea165365ed7777e70b7 Reviewed-on: https://chromium-review.googlesource.com/1140284 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#575739}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .