tree 0ff53eb9ceb44e9b0555fe79bf1044491a64be3f
parent 4cecdffdf93141e3e62cf3dc5c2edb1aa5fd2be7
author Ian Clelland <iclelland@chromium.org> 1744917041 -0700
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1744917041 -0700

Revert "Use base::cstring_view in base::Environment"

This reverts commit 197604a7e5581884f8d017a1eca88a5070bac89d.

Reason for revert: Causes compile failure on linux64-rel-ready builder:
See https://ci.chromium.org/ui/p/chrome/builders/ci/linux64-rel-ready/46753/ and subsequent builds.

Original change's description:
> Use base::cstring_view in base::Environment
>
> Before this change, it was possible to pass a string that didn't
> have a terminating null character. To account for this, some of the
> functions created a temporary std::string, nullifying the point of
> the string_view. In addition, this temporary std::string was not
> created in every function.
>
> This is now fixed by using base::cstring_view.
>
> This change required modifying a couple existing constants to be
> fully defined at the call site.
>
> Change-Id: I5e28a4df4623d7ce9a13cfcf4b54a0194daf89d8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6418733
> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Amelie Schneider <amelies@google.com>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1448397}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8ca8ca0786c0d834ffc91d62028aaccb8cc5424c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6470383
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Owners-Override: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1448488}