commit | c6035c5bd62984653f0a52dd15698790732c92ae | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Wed Jan 15 14:02:16 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 15 14:02:16 2020 |
tree | 257c0a9d3fe0cc9426a4259ab16f5bba504fed55 | |
parent | 96816b4044136fe38757da6950ff18321460a024 [diff] |
[css-pseudo] Implement LayoutNG normal markers as real pseudo-elements Before this patch, list markers were only pseudo-elements when 'content' was different than 'normal'. Otherwise they were anonymous boxes. This makes them be pseudo-elements in that case too. This only affects LayoutNG, in legacy they continue being anonymous. BUG=457718 TEST=accessibility/aria-owns-sends-notification.html TEST=editing/selection/drag-to-contenteditable-iframe.html TEST=editing/selection/selectNode.html TEST=editing/selection/selectNodeContents.html TEST=external/wpt/css/css-pseudo/marker-computed-size.html TEST=external/wpt/css/css-pseudo/marker-content-014.html TEST=blink_unittests --gtest_filter=NGInlineCursorTest/NGInlineCursorTest.NextWithListItem/* TEST=blink_unittests --gtest_filter=ParameterizedTextPaintTimingDetectorTest.CapturingListMarkers/* TEST=content_browsertests --gtest_filter=All/DumpAccessibilityTreeTest.AccessibilityLi/* marker-content-014.html still fails in legacy since markers are not pseudo-elements yet. marker-computed-size.html also fails in legacy, and one of the subcases fails in LayoutNG since 'content: none' doesn't work yet in ::marker. fast/multicol/span/list-multi-column-crash.html now crashes with LayoutNGBlockFragmentation enabled due to bug 1040947. The crash was already happening with ::before and ::after, so it's expected. Change-Id: I51d9661f32b2e1c0c392c261853f8127b74136fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985952 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#731964}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .