commit | c64adae0b7de8cbf4b85b3b00557ddb0555ccf81 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Mon Feb 05 18:56:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 05 18:56:08 2018 |
tree | 701d144c21f97a52ad12561c443b2621ff5a0105 | |
parent | eaef95eb843a160ace9e802ebf6b45ac1d509292 [diff] |
Moved some duplicate password_manager constants into shared code chrome/browser/password_manager had a couple of trivial constants and helper functiosn defined multiple times. In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. With multiple definitions of a constant, with the same name, you get compilation errors. In preparation for jumbo in chrome/browser, this patch moves the constants into the shared file and it removes a random constant for "". The code doesn't normally use constants for "". Bug: 746957 Change-Id: I069e6c9e18b23ce4597c9f23aee829f85e2d17a1 Reviewed-on: https://chromium-review.googlesource.com/897814 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534438}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .