Google Git
Sign in
chromium / chromium / src / c80f42d60b730623d7fea80b70b92987226ca581
commitc80f42d60b730623d7fea80b70b92987226ca581[log] [tgz]
authorBret Sepulveda <bsep@chromium.org>Fri Mar 22 23:42:15 2019
committerCommit Bot <commit-bot@chromium.org>Fri Mar 22 23:42:15 2019
treef449bc064eafb84a42dedb33be4f7a66f14653e2
parent63f598a1904005ddbd3681bcf1baadd4f19b7e92 [diff]
Validate TestRenderViewHost downcast in TestWebContents.

crrev.com/c/1515904 managed to land with an invalid downcast in
TestWebContents::GetRenderViewHost which was only caught by the CFI bot.
This patch adds some manual RTTI and checks the cast, to avoid a future
test using TestWebContents without the right dependencies.

Change-Id: I40cd2a9ae22cc611f94a5b11050d1eb06f428c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529912
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643610}
5 files changed
tree: f449bc064eafb84a42dedb33be4f7a66f14653e2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .