commit | ca6ad81d1991a64b72738e77d5ea8c7a8aa02213 | [log] [tgz] |
---|---|---|
author | edchin <edchin@chromium.org> | Tue May 21 18:51:45 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 21 18:51:45 2019 |
tree | 83c7d118af316902bb4a739a06d93ab91ad51b4a | |
parent | 9e4e153b6a769dbdd95c7619e143018fba71b73e [diff] |
[ios] Fix crash when last incognito is destroyed while presenting BVC It is possible to have the browserState destroyed while the BVC is being presented. This can happen when the following occur: a) There is JS that closes the last incognito tab, b) that JS was paused while the user was in the tab switcher, c) the user enters the tab, activating the JS while the tab is being presented. Effectively, the BVC finishes presentation, but the tab and the whole incognito BrowserState no longer exists. Attempting to present bubbles will crash since bubblePresenter requires a valid BrowserState. When the browserState is invalid in BVC, the only appropriate action is to dismiss the BVC and return the user to the tab switcher. Bug: 934420 Change-Id: Idf6b4d28cebaac1a9e55c52a1ef731a6fedb2c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621311 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#661831}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .