Google Git
Sign in
chromium / chromium / src / cb535aba21b1af92648e95a3299d6aca8a18dbdb
commitcb535aba21b1af92648e95a3299d6aca8a18dbdb[log] [tgz]
authorJinho Bang <jinho.bang@samsung.com>Mon May 20 17:31:13 2019
committerCommit Bot <commit-bot@chromium.org>Mon May 20 17:31:13 2019
tree682d5bfd84a4cdd4038deb806c38da22bb02e8bf
parent1e770fc425cf89de0ad7ee395dee4befd95e79aa [diff]
PaymentHandler: Fix change-payment-method.https.html test

Before this patch, TypeError occurs due to the wrong order of test
scripts. The error causes test failure and shutting down but service
worker registration might be going on different thread. At that time,
the service worker might not register to a finish and might cause DB
errors internally. It might eventually cause a crash due to DCHECK.
So, this patch fixes the wrong order of test scripts. After this patch,
TypeError no longer occurs and we guarantee that service worker is
activated at least.

Bug: 964158
Change-Id: Id8ebe86de3c558e81aad732c6ef6b513647f6465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619531
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661388}
2 files changed
tree: 682d5bfd84a4cdd4038deb806c38da22bb02e8bf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .