Google Git
Sign in
chromium / chromium / src / cba84e5c10c1e5e6d180854c29efce3e0eb41633
commitcba84e5c10c1e5e6d180854c29efce3e0eb41633[log] [tgz]
authorMaksim Moskvitin <mmoskvitin@google.com>Thu Feb 21 12:28:01 2019
committerCommit Bot <commit-bot@chromium.org>Thu Feb 21 12:28:01 2019
tree5390d103cc9df63307844006159adc7e95baaaa7
parent30e7d06cc9c089c52b0921a78ab9218c3db0ddfe [diff]
[SendTabToSelf] Remove usages of SEND_TAB_TO_SELF as UserSelectableType

SEND_TAB_TO_SELF is not a user selectable type and will probably never
be. GetChosenTypes() and SetChosenTypes() methods in sync_user_settings
are supposed to work only with user selectable types. Usages were
replaced with GetPreferredTypes().

In tests ProfileSyncServiceMock was replaced with TestSyncService,
because first one doesn't allow direct manipulation of preferred types.

Bug: 926279, 906611, 910518
Change-Id: I17510eccddb1f40113c52da06222a7c6a7f704c8
Reviewed-on: https://chromium-review.googlesource.com/c/1478794
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#634159}
2 files changed
tree: 5390d103cc9df63307844006159adc7e95baaaa7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .