commit | cbff2fc55da8deec86ae00824a206eb0a6505af4 | [log] [tgz] |
---|---|---|
author | Dirk Pranke <dpranke@chromium.org> | Fri Mar 22 21:53:44 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 22 21:53:44 2019 |
tree | 9227ed7c39f5cb4f565882f6132e7b0f9e7e92db | |
parent | 65d88e35356f4f6bdaf47e83631ed30c8c39569d [diff] |
Add ensure_gn_version.py and DEPS hook. In r641353, I switched from using download_from_google_storage to download GN binaries to using CIPD. Unfortunately, I chose to install the binary into the same location we were using previously, which, while convenient, meant that we might hit cases where someone would sync back to a pre-cipd version of the checkout, run the old hook to download an old version of GN, and then sync back to tip-of-tree, and CIPD wouldn't know that the binary got clobbered. This could lead to really weird errors. This CL adds a hook to DEPS to check that have the right version of GN, and, if not, forcibly download and install it again. In the common case, the hook should be very fast. Ultimately we want to modify CIPD to actually validate that the files it thinks are installed are in fact right. Bug: 944367 Change-Id: I86d3eeaf9ef232e4d472d36db54a40458702078e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534554 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#643568}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .