blob: 2293ecc884c088a48e693f820825f1194ae888b2 [file] [log] [blame]
<?xml version="1.0" encoding="UTF-8"?>
<issues format="5" by="lint 4.1.0" client="cli" variant="all" version="4.1.0">
<issue
id="WrongConstant"
message="Must be one or more of: Gravity.LEFT, Gravity.RIGHT, GravityCompat.START, GravityCompat.END"
errorLine1=" if (mDrawerLayout.isDrawerOpen(Gravity.START)) {"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Chromoting.java"
line="204"
column="40"/>
</issue>
<issue
id="WrongConstant"
message="Must be one or more of: Gravity.LEFT, Gravity.RIGHT, GravityCompat.START, GravityCompat.END"
errorLine1=" mDrawerLayout.closeDrawer(Gravity.START);"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Chromoting.java"
line="205"
column="39"/>
</issue>
<issue
id="WrongConstant"
message="Must be one or more of: Gravity.LEFT, Gravity.RIGHT, GravityCompat.START, GravityCompat.END"
errorLine1=" if (mDrawerLayout.isDrawerOpen(Gravity.START)) {"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Chromoting.java"
line="292"
column="56"/>
</issue>
<issue
id="WrongConstant"
message="Must be one or more of: Gravity.LEFT, Gravity.RIGHT, GravityCompat.START, GravityCompat.END"
errorLine1=" mDrawerLayout.closeDrawer(Gravity.START);"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Chromoting.java"
line="293"
column="55"/>
</issue>
<issue
id="WrongConstant"
message="Must be one or more of: Gravity.LEFT, Gravity.RIGHT, GravityCompat.START, GravityCompat.END"
errorLine1=" mDrawerLayout.openDrawer(Gravity.START);"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Chromoting.java"
line="295"
column="54"/>
</issue>
<issue
id="UseCompatTextViewDrawableXml"
message="Use `app:drawableStartCompat` instead of `android:drawableStart`"
errorLine1=" android:drawableStart=&quot;@drawable/ic_host_online&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/res/layout/host_online.xml"
line="28"
column="9"/>
</issue>
<issue
id="SetJavaScriptEnabled"
message="Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully"
errorLine1=" mWebView.getSettings().setJavaScriptEnabled(true);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/help/HelpActivity.java"
line="91"
column="9"/>
</issue>
<issue
id="SetJavaScriptEnabled"
message="Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully"
errorLine1=" webView.getSettings().setJavaScriptEnabled(true);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/WebViewActivity.java"
line="46"
column="9"/>
</issue>
<issue
id="Recycle"
message="This `MotionEvent` should be recycled after use with `#recycle()`"
errorLine1=" event = MotionEvent.obtain(event);"
errorLine2=" ~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java"
line="207"
column="29"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Chromoting.java"
line="628"
column="13"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Desktop.java"
line="183"
column="13"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Desktop.java"
line="221"
column="20"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Desktop.java"
line="280"
column="13"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Desktop.java"
line="512"
column="13"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Desktop.java"
line="521"
column="13"/>
</issue>
<issue
id="ObsoleteSdkInt"
message="Unnecessary; SDK_INT is always >= 21"
errorLine1=" if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/Desktop.java"
line="605"
column="13"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view `DesktopView` overrides `onTouchEvent` but not `performClick`"
errorLine1=" public final boolean onTouchEvent(MotionEvent event) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../remoting/android/java/src/org/chromium/chromoting/DesktopView.java"
line="85"
column="26"/>
</issue>
<issue
id="RtlEnabled"
message="The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest">
<location
file="gen/remoting/android/remoting_apk__lint/gen/remoting/android/AndroidManifest.xml"/>
</issue>
</issues>