commit | d0daef0dc485855ed768878c0d3d574597f64920 | [log] [tgz] |
---|---|---|
author | Alan Cutter <alancutter@chromium.org> | Wed Jan 16 05:43:48 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 16 05:43:48 2019 |
tree | f614a767246aa64aa0dd06f6c6e45eac0876492f | |
parent | d5f593588243971cd6a3686b4b94ab729ceb7efa [diff] |
Plumb ShowEmojiPanel call through to app shim process on Mac This CL moves the call to ui::ShowEmojiPanel from the browser process to the app shim process for PWA windows on Mac via the following path: RenderViewContextMenu::ExecuteCommand -> BrowserWindow/BrowserView -> Widget -> NativeWidgetMac --mojo--> BridgedNativeWidget/BridgedNativeWidgetImpl -> ui::ShowEmojiPanel() All other platforms will continue to call ui::ShowEmojiPanel() from the browser process. This fixes the "Emoji & Symbols" context menu entry for PWA text fields (in views and the web) on Mac. Web contents text field: https://bugs.chromium.org/p/chromium/issues/attachment?aid=375066&signed_aid=lq0pCXn7JRKe2K7sB--yMg==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=375067&signed_aid=zWSSoCeJA0cCWd9UqEC1-g==&inline=1 Views text field: https://bugs.chromium.org/p/chromium/issues/attachment?aid=375068&signed_aid=7zm-2jnWqB1UCPCk3XbQMA==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=375069&signed_aid=l5rcTwTlu-Kk2lKjYW2GyQ==&inline=1 Bug: 919167 Change-Id: Ia080e1bb13979d1cca920407d5a4e8ecacca791e Reviewed-on: https://chromium-review.googlesource.com/c/1410406 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#623125}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .