Remove API SchemeRegistry::ShouldTreatURLSchemeAsNoAccess()

This CL replaces the only use of ShouldTreatURLSchemeAsNoAccess() with a
direct call to the corresponding url::GetNoAccessSchemes() API. This
removes the need to store a copy of the no-access schemes in
SchemeRegistry, which is not kept in sync with the one from url_utils.
In particular, this improves consistency between SecurityOrigin's
ShouldTreatAsOpaqueOrigin and SchemeHostPort's and fixes the following
DCHECK failure when running the test
SecurityOrigin.StandardNoAccessScheme added in crbug.com/2602402:

[FATAL:security_origin.cc(158)] Check failed: url::SchemeHostPort(protocol.Utf8(), host.Utf8(), port, url::SchemeHostPort::CHECK_CANONICALIZATION) .IsValid().
base::debug::CollectStackTrace()
base::debug::StackTrace::StackTrace()
logging::LogMessage::~LogMessage()
logging::LogMessage::~LogMessage()
blink::SecurityOrigin::SecurityOrigin()
blink::SecurityOrigin::SecurityOrigin()
blink::SecurityOrigin::CreateWithReferenceOrigin()
blink::SecurityOrigin::CreateFromString()
blink::SecurityOriginTest_StandardNoAccessScheme_Test::TestBody()

Bug: 888079, 1021779, 1020201
Change-Id: I7d8481389bd64ccc09f60b31ca6d7291ebedaa7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637593
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#845075}
3 files changed
tree: 73c45add2f25668c96fb65ab508f1629ff09ffd9
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codelabs/
  38. codereview.settings
  39. components/
  40. content/
  41. courgette/
  42. crypto/
  43. dbus/
  44. device/
  45. docs/
  46. extensions/
  47. fuchsia/
  48. gin/
  49. google_apis/
  50. google_update/
  51. gpu/
  52. headless/
  53. infra/
  54. ios/
  55. ipc/
  56. jingle/
  57. media/
  58. mojo/
  59. native_client_sdk/
  60. net/
  61. pdf/
  62. ppapi/
  63. printing/
  64. remoting/
  65. rlz/
  66. sandbox/
  67. services/
  68. skia/
  69. sql/
  70. storage/
  71. styleguide/
  72. testing/
  73. third_party/
  74. tools/
  75. ui/
  76. url/
  77. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.