Google Git
Sign in
chromium / chromium / src / af91372fe82b802c7a777bff834c58db2fec8af5
commitaf91372fe82b802c7a777bff834c58db2fec8af5[log] [tgz]
authorSergio Villar Senin <svillar@igalia.com>Fri Dec 14 14:32:42 2018
committerCommit Bot <commit-bot@chromium.org>Fri Dec 14 14:32:42 2018
tree9ab5cc690893144f4683c7665641e0bbfa0d88ee
parentbba8a6887b09a8b5be71426272d7721f3df4df6b [diff]
Remove DiagnosticObserver::NotifySigninValueChanged() and its usage

The semantics of this observer method are strange and unclear, and
rather than fixing it up, we can just eliminate it as it is used only
in legacy code.

By removing this we can cleanup the API surface of SigninManager and
IdentityManager.

Bug: 913850
Change-Id: I7e7ebc455eaab208d57b91f7398055f62a915af5
Reviewed-on: https://chromium-review.googlesource.com/c/1373453
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616665}
9 files changed
tree: 9ab5cc690893144f4683c7665641e0bbfa0d88ee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .