tree 64946c552630da03e28a0180fb87edede4eb9253
parent d415a1ee570ae7d698030f393e6b0cde83fd190a
author Justin Lulejian <jlulejian@chromium.org> 1684949643 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1684949643 +0000

[Extensions] [Reland] Change install directory of .zip file installs.

Note: patchset 1 contains the original change (crrev.com/c/4313024) with
a minor merge conflict fix, but is virtually the same. Patchset 2+
contains the new changes that fix the reason for the revert.

Before the new changes .zip installs would be deleted by the automated
garbage collector inside the profile directory.

Summary of changes since reland:

extension_garbage_collector.cc/h: Added a new method called
`CheckUnpackedExtensionDirectory(...)` that applies different logic to
unpacked directories when cleaning them up.

extension_garbage_collector_chromeos.cc: due to changes in
extension_garbage_collector.cc/h this needed a change to adjust for
unpacked.

extension_garbage_collector_unittest.cc: Added a new test to ensure we
do not delete an extension.

extension_service_unittest.cc:
ExtensionServiceTest.LoadAllExtensionsFromDirectorySuccess increase
the expected pref key count because we've added one.

PreferencesUnzipped: Removed, as I was able to bring the extension into
the existing test Preferences file.

Low-Coverage-Reason: extension_service_test_base.cc is large enough to
probably need tests, but that is out of scope for this CL.

Bug: 1378775
Change-Id: I0cc84af56e4824d027d4125037391d0abb117402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4521433
Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148621}