commit | d2dcd09c81f94f9f915ecb70667ae31dd2a7995e | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Mon Feb 11 17:44:27 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 11 17:44:27 2019 |
tree | 59bac4ec696baca4e90e319dcf0ce0c30f6ce5d6 | |
parent | 08dc7d03d74c2cf814236177521361c5bb8c7f34 [diff] |
Update IdentityManager::SetAccountsInCookie() to take a callback invoked on completion This CL changes GaiaCookieManagerServer::SetAccountsInCookie() to take a base::OnceCallback that gets associated to a GaiaCookieRequest instance and invoked upon request handing completion. It allows the removal of OnSetAccountsInCookieCompleted() method from both IdentityManager and GCMS Observer classes, which helps with cleaning this API surface. This is a follow up of [1]. [1] https://crrev.com/c/1446473/4/services/identity/public/cpp/identity_manager.h#141 PS: More observer callbacks can follow a similar pattern, eg OnAddAccountToCookie and LogOut procedures. BUG=927749 Change-Id: Icfc18a2b69fd381f9e431a57a4947a5e1b965d22 Reviewed-on: https://chromium-review.googlesource.com/c/1456518 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#630822}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .