tree 1a1e5d25563f3fb0432dacec775f77d894e92d64
parent 0da11caeb8e20c78cdc11c6f48ef386a0d113b6e
author Robbie McElrath <rmcelrath@chromium.org> 1551403895 +0000
committer Commit Bot <commit-bot@chromium.org> 1551403895 +0000

Fix URLLoaderFactory use-after-free in NetworkPortalDetectorImpl

NetworkPortalDetectorImpl uses a raw pointer to the
SystemNetworkContextManager's URLLoaderFactory, which will be invalid
if mojo pipe runs into any issues. This CL makes it use a
SahredURLLoaderFactory instead, which will handle failures
automatically.

Bug: 936625
Change-Id: I2ea71ef6cc46440f66349729e16cc2558ef145b1
Reviewed-on: https://chromium-review.googlesource.com/c/1495748
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636645}