Google Git
Sign in
chromium / chromium / src / dbd7f8723c13e5b23ea44b68850732df40c7f5e5
commitdbd7f8723c13e5b23ea44b68850732df40c7f5e5[log] [tgz]
authorChris Hamilton <chrisha@chromium.org>Wed Aug 01 23:38:38 2018
committerCommit Bot <commit-bot@chromium.org>Wed Aug 01 23:38:38 2018
treea4721073dc91398d0eca453e8f774562f27fcd3f
parent805e3710b293694b5ef613bfd9589dd7f47412cf [diff]
Fix use after free in I18nSourceStream.

This adds explicit lifetime management between URLRequestChromeJob and
URLDataSourceImpl, by having the job own a shared_refptr to the data
source. This allows the data source to be detached from the backend
yet remain alive as long as the request job is still alive (which
eventually wants to use its i18n template replacements map).

BUG=863318

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I84caa70dff1e1c65ac430fca11656e85e4a6eebd
Reviewed-on: https://chromium-review.googlesource.com/1156625
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579994}
3 files changed
tree: a4721073dc91398d0eca453e8f774562f27fcd3f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .