commit | dc2c5126634d0574fe02ec7c839e6dd2f07432ed | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Tue Nov 06 14:37:38 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Nov 06 14:37:38 2018 |
tree | 90f7930940209070eaf52fe767e54dd7919efb2b | |
parent | ab5e68c38f8fc1a3c6ae682cd554e2528367b6c3 [diff] |
Create initial split of //components/signin into internals/externals //components/signin/core/browser contains three different types of code: 1. Code that forms the guts of IdentityManager and will form the guts of the Identity Service implementation (e.g., SigninManager). 2. Code that will be clients of IdentityManager (e.g., SigninTracker). 3. Code that will be used on both sides (e.g., AccountInfo). Currently, all of these are naturally grouped in the same GN target, since there was never any distinction between them. However, we need to separate them in GN now to enable converting the code in 2 to use IdentityManager. This split will also define the scope of the conversion of the codebase to IdentityManager: everything that is in 1 will need to have its clients converted to use IdentityManager. This CL performs an initial split, via the following process: - Moved signin_manager(_base).*, profile_oauth2_token_service.*, and account_tracker_service.* into a new "internals" target that the existing target now depends on. - Kept moving in code (and adding dependencies as needed) until "gn check" no longer complained about the "internals" target including code that wasn't in any dependencies. This CL also modifies //services/identity/public/cpp to depend only on //components/signin/core/browser:internals; this change is is the concrete benefit from doing the split, as it is what will allow us to convert client code in //components/signin/core/browser. Future CLs will refine the split, but this is a good initial checkpoint. Bug: 901859 Change-Id: Ied46c4cdf0153b78b53516fec9537a83c4c0a71d Reviewed-on: https://chromium-review.googlesource.com/c/1317915 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#605671}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .