commit | dc76bd1252ad56309ecad13729305c94b1f57ba7 | [log] [tgz] |
---|---|---|
author | Alice Boxhall <aboxhall@chromium.org> | Wed Dec 12 02:11:12 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 12 02:11:12 2018 |
tree | 953d976722e8b241db6d4fe5da32e3a1bb3368b7 | |
parent | 2ec822d31671f6941cc60159fd576c52a61dce04 [diff] |
Revert "Remove code to store the last popup transiently in WebFrameWidgetImpl" This reverts commit 573f46751824b8dcfbec675291eacc8c581ae441. Reason for revert: Seems to be causing EffectiveTouchActionPropagatesAcrossNestedFrames to fail https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927388648425983952/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames/0 Original change's description: > Remove code to store the last popup transiently in WebFrameWidgetImpl > > This code was copied over from WebViewImpl when adding the HidePopups > call in order to have a pinch zoom or scroll tap outside the current > popup in a non-main-frame-local-rooted iframe hide the current popup. > > This is modifying state on WebViewImpl meant to track between TapDown > and Tap, to avoid the Tap showing a popup that was hidden by TapDown. > > WebFrameWidgetImpl does not show popups on Tap, and if it did, it > should track this transient state locally not on WebViewImpl. > > Also remove the undocumented FALLTHROUGH which was not explained > in 671732 as it now goes to nothing. > > R=dcheng@chromium.org > > Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db > Bug: 912193, 671732 > Reviewed-on: https://chromium-review.googlesource.com/c/1372539 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615708} TBR=danakj@chromium.org,dcheng@chromium.org,wjmaclean@chromium.org Change-Id: Ifddbb605fc6165505774105d5618d57b62e3159c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912193, 671732 Reviewed-on: https://chromium-review.googlesource.com/c/1372110 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615783}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .