commit | dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125 | [log] [tgz] |
---|---|---|
author | Bence Béky <bnc@chromium.org> | Sun Feb 11 01:32:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Feb 11 01:32:29 2018 |
tree | 72768018c833c4c43d3e1fd12df8a11bc2e9609e | |
parent | 9a256b99c45032b63afad4449fce924a52ae3fe4 [diff] |
Misc cleanup: remove unused, fix comment, improve logging. Change logging in StaticSocketDataHelper::VerifyWriteData() such that if writted data does not match mock write, then print actual written data in full length, not only truncated to the length of the mock write data. Remove unused StaticSocketDataProvider:CompleteRead(). The rest of this CL belongs to https://crbug.com/810752: Inline ConstructSpdyGoAway() as ConstructSpdyGoAway(0). Remove unused struct SpdyHeaderInfo. Remove obsolete "The caller takes ownership of the frame." comment from spdy_test_util_common.h, leftover from when methods used to return raw pointers. This is a follow-up to https://crrev.com/2156643002/diff/1/net/spdy/spdy_test_util_common.h. Also remove useless "Returns a SpdySerializedFrame." comments from the line above the definition showing return type SpdySerializedFrame. Bug: 600438, 810752 Change-Id: I1f3471f4e4a9b71603257cf82986d0efe0288c7f Reviewed-on: https://chromium-review.googlesource.com/912013 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#535993}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .