commit | dced8a077c8924ae3f08a9643236483e39e46a7c | [log] [tgz] |
---|---|---|
author | Dana Fried <dfried@chromium.org> | Thu Mar 28 17:49:50 2019 |
committer | Dana Fried <dfried@chromium.org> | Thu Mar 28 17:49:50 2019 |
tree | 558e04da99abfa141325171d22c6d7cb9608e029 | |
parent | 65ce7cbe76ed194369c3d22df6dd2d9e2cfa16a4 [diff] |
Don't regenerate browser frame on native theme changes. BrowserView was calling BrowserFrame::FrameTypeChanged() whenever the native theme changed. While Chrome theme changes can indeed cause frame changes, native theme changes should largely be color-based and should not require re-creation of the frame and re-composition of the entire window. This was causing flicker, which was especially pronounced on older machines and computers running Windows 8.x. See attached bug for details. TBR=dfried@chromium.org (cherry picked from commit b153488cab7173359d93cc0c64af13125d857619) Bug: 945138 Change-Id: I002a6535de507866b781643ce9afb81002c6946c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538984 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#644544} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544153 Reviewed-by: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#511} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .