Google Git
Sign in
chromium / chromium / src / dced8a077c8924ae3f08a9643236483e39e46a7c
commitdced8a077c8924ae3f08a9643236483e39e46a7c[log] [tgz]
authorDana Fried <dfried@chromium.org>Thu Mar 28 17:49:50 2019
committerDana Fried <dfried@chromium.org>Thu Mar 28 17:49:50 2019
tree558e04da99abfa141325171d22c6d7cb9608e029
parent65ce7cbe76ed194369c3d22df6dd2d9e2cfa16a4 [diff]
Don't regenerate browser frame on native theme changes.

BrowserView was calling BrowserFrame::FrameTypeChanged() whenever the
native theme changed. While Chrome theme changes can indeed cause frame
changes, native theme changes should largely be color-based and should
not require re-creation of the frame and re-composition of the entire
window. This was causing flicker, which was especially pronounced on
older machines and computers running Windows 8.x.

See attached bug for details.

TBR=dfried@chromium.org

(cherry picked from commit b153488cab7173359d93cc0c64af13125d857619)

Bug: 945138
Change-Id: I002a6535de507866b781643ce9afb81002c6946c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538984
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644544}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544153
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#511}
Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880}
5 files changed
tree: 558e04da99abfa141325171d22c6d7cb9608e029
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .