tree 2f83884d3641544ddf9b01edf746f5e0b9b3a96f
parent b66b0b1ba61d0f0d4bb745d6a643e3da6128306f
author Rachel Wong <wrong@chromium.org> 1639018495 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1639018495 +0000

Reland "Only filter out subsettings with lower scores."

This is a reland of 8acb8d8cc2fa037c51cf3ca1365ba06db85d5b16

The original CL was reverted due to suspected Tast failures, but it
was not the culprit. See https://bugs.chromium.org/p/chromium/issues/detail?id=1278130#c7.


Original change's description:
> Only filter out subsettings with lower scores.
>
> The launcher settings search currently filters out all sub-settings or
> sub-sections which contain an ancestor in the results page. This is
> sometimes bad because the specific setting is actually the desired
> result (see the crbug for an example).
>
> This CL changes filtering so that only sub-settings with an equal or
> worse score than their ancestor get filtered out.
>
> Tested on device with some common queries to check that results are
> still good.
>
> Bug: 1267815
> Change-Id: Id9935295cb4731a9cf1af6121c08568648331e8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320655
> Reviewed-by: Tony Yeoman <tby@chromium.org>
> Commit-Queue: Rachel Wong <wrong@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#949385}

Bug: 1267815
Change-Id: Iaf01b6296550773b45d7b46e1e110406f6f804e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325325
Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#949903}