commit | de12bc444834cea208a809629ca347fcec39e93f | [log] [tgz] |
---|---|---|
author | Ella Ge <eirage@chromium.org> | Thu Nov 15 20:51:44 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 15 20:51:44 2018 |
tree | 9a8c367538aec79ebb58a6686b6c8822525e81e2 | |
parent | 9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a [diff] |
Revert "Fix video quad rect and surface output rect" This reverts commit 1dfd4418faf858a63bd901ef0485c7e54e5e69fb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Fix video quad rect and surface output rect > > Video surface output rect didn't take rotation into account so when > SurfaceAggregator would stretch content to fill bounds, it would end up > with the wrong scaling factors (squash in one dimension and expand in > another) since the surface quad's bounds (in the embedder) were rotated. > > To work around this (or by accident), VideoFrameResourceProvider was > passing the rotated size as the quad's rect which doesn't make sense > intuitively. This also worked by accident with DirectComposition > overlays because of applying another scaling which would fix the aspect > ratio again. > > This change makes it possible to use the |quad_to_target_transform| as > is, without having to apply an aspect ratio correcting scaling, and to > assume that the quad's rect is in the pre-transform space. > > Bug: 904035 > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 > Reviewed-on: https://chromium-review.googlesource.com/c/1334971 > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608495} TBR=kbr@chromium.org,enne@chromium.org,sunnyps@chromium.org,liberato@chromium.org Change-Id: I99727abc125468581caa0cf9e2ddea74351dd1f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904035 Reviewed-on: https://chromium-review.googlesource.com/c/1338206 Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608501}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .