commit | c71812f1007dae45bce45b451c384bf9c0dbd356 | [log] [tgz] |
---|---|---|
author | Dan Beam <dbeam@chromium.org> | Fri Dec 07 02:41:39 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 07 02:41:39 2018 |
tree | 548df493ccd59e81b382337c8089e4a49aaf7c70 | |
parent | be2a6c46ff867eec74b7f338a849ef67a86fc546 [diff] |
Revert "Enable warmer welcome during Assistant launch." This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088. Reason for revert: ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout Original change's description: > Enable warmer welcome during Assistant launch. > > 1. It is guarded by a finch flag AssistantWarmerWelcome. > 2. WW only shows 3 times. > > Bug: b:112495005 > Test: Manual > > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1355174 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#614553} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:112495005 Reviewed-on: https://chromium-review.googlesource.com/c/1366873 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#614577}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .