)]}' { "commit": "df7f78e35f95dfae098dd6197b012e0506f68e0f", "tree": "c34e71a22f1090e0c234723942bcedc1a80a53a0", "parents": [ "4bda9631249437632070c20e6a31bb10c0cc608e" ], "author": { "name": "joone.hur", "email": "joone.hur@intel.com", "time": "Mon Oct 03 19:06:15 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 03 19:09:35 2016" }, "message": "Make File-Picker modal on Linux\n\nChromium for Linux uses GtkFileChooserDialog for opening a file-picker,\nbut it is not modal to the X11 host window because GtkFileChooserDialog\ncan be modal only to the parent GtkWindow.\n\nThis patch allows the X11 host window to disable input event handling\nto make a file-picker modal.\n\nDesign doc and discussion:\nhttps://docs.google.com/document/d/12CfKVTpaonxxM3sNksq6vY6qb0J2qR3b7h_bLxzYanE\n\nThis CL was reverted due to the UI freezing problem that happens when the\nusers open a file-picker from a child window of the X11 host window:\nhttps://codereview.chromium.org/1594973009\n\nBUG\u003d408481,579408\nTEST\u003dBrowserSelectFileDialogTest.ModalTest\n\nReview-Url: https://codereview.chromium.org/1624793002\nCr-Commit-Position: refs/heads/master@{#422482}\n", "tree_diff": [ { "type": "modify", "old_id": "4cea81df9fd4eb23814576c79c8d4b6a2d8c500a", "old_mode": 33188, "old_path": "chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc", "new_id": "d37f9be03c1e32e364f41512be8e72cbd2f3e610", "new_mode": 33188, "new_path": "chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc" }, { "type": "modify", "old_id": "12b4c926f2ca809ab761f755cff6c6c61ca6429d", "old_mode": 33188, "old_path": "chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc", "new_id": "3fd66fff3ea2b1a13ab5cd06ab017ffa0a0b6117", "new_mode": 33188, "new_path": "chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc" }, { "type": "modify", "old_id": "ded7f22d3b2b92119e91294ede6fc467c74269e1", "old_mode": 33188, "old_path": "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc", "new_id": "816faa3f312f4ef52ff418a99b5e3d7016ac760c", "new_mode": 33188, "new_path": "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc" }, { "type": "modify", "old_id": "07e35cabb1abd6d4bfac08a3b561311d1aa6a4b6", "old_mode": 33188, "old_path": "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h", "new_id": "a4b68b382218dec15d642952423d1fa23f8bb604", "new_mode": 33188, "new_path": "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h" } ] }