commit | df852a77436e9dee4613433143533d2ca348851a | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Mon Jan 14 17:22:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 14 17:22:07 2019 |
tree | f19090686362dfb8e5dd19c14a45159643d9a9e6 | |
parent | 14be14a131d6202cea486264d43c8255f68d60e3 [diff] |
Get chromium's major version directly instead of parsing strings Getting Chromium's version is not trivial in code and some code got the version string dynamically during runtime and parsed it. Since several files defined the same helper function GetCurrentMajorVersion, those clashed in some extreme jumbo builds. This drops this function and instead gets the version directly from the version system via a C/C++ define. Since the version number now will be compiled into autofill, it will have to recompile if the major version number changes. Bug: 907570 Change-Id: I5823d977f3ff58c4b19f173c01031d4a9aa5c56c Reviewed-on: https://chromium-review.googlesource.com/c/1409548 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#622490}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .