Google Git
Sign in
chromium / chromium / src / dfb35c5985c749f1f12574dbf02a0ff8e9dfe5b3
commitdfb35c5985c749f1f12574dbf02a0ff8e9dfe5b3[log] [tgz]
authorEdin Kadric <edin@google.com>Thu Jan 10 09:25:29 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 10 09:25:29 2019
tree7199fad520877922fa4338127618e23f6e8080a5
parent25ece8e7574112efedb141a28bc3755e3a0173d7 [diff]
Use monospaced font for passwords in password manager bubble.

This sets the label to a monospace font depending on the OS:
MacOS - Menlo
Windows - Consolas
Chrome OS - DejaVu Sans Mono
Linux - DejaVu Sans Mono

Also involves changing the font list caching in resource_bundle.cc to receive typeface as parameter and add it to the caching key, instead of only supporting a default font.

Support for comboboxes will be added in a future CL (which will be able to reuse some of the work done here).

Tested on Mac. I have a Linux workstation that I will test it on next, but I don't have Windows and ChromeOS.

Screenshots attached to corresponding bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=768825

Bug: 768825
Change-Id: Ie94cec7045dafd1346263c383ca08edd5560d8f5
Reviewed-on: https://chromium-review.googlesource.com/c/1378643
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621517}
5 files changed
tree: 7199fad520877922fa4338127618e23f6e8080a5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .