tree 282c4266d0cb5cc2d1f5c696499d745448b821f2
parent 31ec2ef92bdd9419cd1301689c2203610e44f910
author Daniel Murphy <dmurph@google.com> 1666641806 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1666641806 +0000

[dPWA] Refactoring launches to always be async.

Context:
Reading information from the WebAppProvider system is often inherently
racy (given all of our async data sources). Putting operations behind
commands guarantees the the data read is not going to change across
async calls (and that you aren't reading it in the middle of an
operation like 'install', 'uninstall', etc).

This project protects 'launch' to make sure it doesn't happen during
an 'uncommitted read' state.

This change was created by using 'git cl split', and is the first part
in making dPWA launches async. The app service is designed to have
launches be async (and in lacros they will ALWAYS be async), but
currently they are "mostly" synchronous. This means that there are a
variety of tests (and even one instance of production code - the
intent launcher) which assumes this. This patch fixes all of those
cases.

Specifically patches split here:
* Add browser or navigation waiters to wait until launches complete in
  tests.
* Modifies the method signatures required for making launches async for
  making launches async (but just calls the callback synchronously for
  now.
* Fixes a future bug for Lacros where the intent navigation closes the
  window before launching the app, causing the browser/profile to start
  shutting down. Keep-alives were added to ensure this does not happen.

There is no functional change in this patch.
If you want to see a patch with all test changes & functionality
changes, see:
https://chromium-review.googlesource.com/c/chromium/src/+/3929017

$description

This CL was uploaded by git cl split.

R=tobyhuang@chromium.org

Bug: b/242059352, 1377102
Change-Id: Ifffb6083d65c69de119475c7720779e579581481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3969023
Reviewed-by: Toby Huang <tobyhuang@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1062966}