commit | e0a45684f1cc9e125daed78cb74c7939415ebadc | [log] [tgz] |
---|---|---|
author | Jinsuk Kim <jinsukkim@chromium.org> | Fri Oct 12 06:07:05 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 12 06:07:05 2018 |
tree | 8f8d9a4b419d4f79b615f84ef133d7393b498117 | |
parent | 9d4f9a68490476ebc67a19242ed76606d57aa853 [diff] |
Android: Ensure single TabWebContentsObserver per Tab TabWebContentsObserver is TabWebContentsUserData which is created for the first active WebContents for a given Tab, and finally destroyed together with the Tab. There was a bug creating multiple instances of the observer for every new active WebContents. This left an instance for old WebContents undestroyed, and caused a reported bug for already nulled out WebContents references while handling an event that should not have been triggered. This CL makes sure there will be a single TabWebContentsObserver for Tab. Bug: 894353 Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312 Reviewed-on: https://chromium-review.googlesource.com/c/1278426 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#599109}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .