commit | e103997a4060fb241d7e91a4bb50879777d79f57 | [log] [tgz] |
---|---|---|
author | Fredrik Söderquist <fs@opera.com> | Mon Mar 11 00:00:20 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 11 00:00:20 2019 |
tree | 4a9c87fec7f0b8f04e1e60a914b54c9a261a0861 | |
parent | 5e1df41b3b8f9151ca803d5deb66312dfc160191 [diff] |
Don't include bindings/core/v8/script_source_code.h in probe template This template is used by both core and platform probes - in the latter case this include would be a layering violation. ---=== GN output: ===--- ERROR at //out/Default/gen/third_party/blink/renderer/platform/platform_probes_inl.h:15:11: Include not allowed. #include "third_party/blink/renderer/bindings/core/v8/script_source_code.h" ^--------------------------------------------------------------- It is not in any dependency of //third_party/blink/renderer/platform:platform The include file is in the target(s): //third_party/blink/renderer/core:core_generated which should somehow be reachable. ---==================--- Specify this include in the 'settings.includes' list in core/probe/core_probes.json5 instead. Bug: 939782 Change-Id: Ibd0ee570ae10408163223a49a27c0fd9ff1529d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511392 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#639361}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .