)]}' { "commit": "e103997a4060fb241d7e91a4bb50879777d79f57", "tree": "4a9c87fec7f0b8f04e1e60a914b54c9a261a0861", "parents": [ "5e1df41b3b8f9151ca803d5deb66312dfc160191" ], "author": { "name": "Fredrik Söderquist", "email": "fs@opera.com", "time": "Mon Mar 11 00:00:20 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 11 00:00:20 2019" }, "message": "Don\u0027t include bindings/core/v8/script_source_code.h in probe template\n\nThis template is used by both core and platform probes - in the latter case\nthis include would be a layering violation.\n\n---\u003d\u003d\u003d GN output: \u003d\u003d\u003d---\n\nERROR at //out/Default/gen/third_party/blink/renderer/platform/platform_probes_inl.h:15:11: Include not allowed.\n#include \"third_party/blink/renderer/bindings/core/v8/script_source_code.h\"\n ^---------------------------------------------------------------\nIt is not in any dependency of\n //third_party/blink/renderer/platform:platform\nThe include file is in the target(s):\n //third_party/blink/renderer/core:core_generated\nwhich should somehow be reachable.\n\n---\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d---\n\nSpecify this include in the \u0027settings.includes\u0027 list in\ncore/probe/core_probes.json5 instead.\n\nBug: 939782\nChange-Id: Ibd0ee570ae10408163223a49a27c0fd9ff1529d8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511392\nReviewed-by: Alexei Filippov \u003calph@chromium.org\u003e\nCommit-Queue: Fredrik Söderquist \u003cfs@opera.com\u003e\nCr-Commit-Position: refs/heads/master@{#639361}", "tree_diff": [ { "type": "modify", "old_id": "86d48b872e96c464a7870d1045f3e5342d9aca2a", "old_mode": 33188, "old_path": "third_party/blink/renderer/build/scripts/templates/instrumenting_probes_inl.h.tmpl", "new_id": "1c7ab5881ba0942044dc0ea966a3486bd0844887", "new_mode": 33188, "new_path": "third_party/blink/renderer/build/scripts/templates/instrumenting_probes_inl.h.tmpl" }, { "type": "modify", "old_id": "54900d63a0cec17dffbd05878a1896400a4856bb", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/probe/core_probes.json5", "new_id": "d957aa0e9da25068b079e185b65f334a16b22be9", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/probe/core_probes.json5" } ] }