Google Git
Sign in
chromium / chromium / src / e1c7c0543ceb3801a191fe15e9bfa16ac6b10d28
commite1c7c0543ceb3801a191fe15e9bfa16ac6b10d28[log] [tgz]
authorDan Beam <dbeam@chromium.org>Fri Jan 18 21:48:08 2019
committerDan Beam <dbeam@chromium.org>Fri Jan 18 21:48:08 2019
tree580a74d1a57a186dea7f488172d60f1ee562980a
parent366a1d932aa48b7d42f6d6f900bfca4a0738fa1c [diff]
Dark Mode: stop light mode styles from bleeding into dark mode buttons

Light mode, secondary paper-button:hover border-color was coming through
because an equivalent variable wasn't being defined for dark mode.

It's very hard to see, but I think the same story was happening for
primary paper-button:active box-shadow.

Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g471d243f08_0_869

R=dpapad@chromium.org
BUG=883049

Change-Id: I3db4f2cde037d33086408e980eea43979cc0fe99
Reviewed-on: https://chromium-review.googlesource.com/c/1420304
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624305}
1 file changed
tree: 580a74d1a57a186dea7f488172d60f1ee562980a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .