net/base/network_isolation_key_unittest.cc - chromium/src - Git at Google

 // Copyright 2019 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

 #include "net/base/network_isolation_key.h"

 #include "base/stl_util.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/values.h"
 #include "net/base/features.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 #include "url/origin.h"

 namespace net {

 TEST(NetworkIsolationKeyTest, EmptyKey) {
   NetworkIsolationKey key;
   EXPECT_FALSE(key.IsFullyPopulated());
   EXPECT_EQ(std::string(), key.ToString());
   EXPECT_TRUE(key.IsTransient());
   EXPECT_EQ("null", key.ToDebugString());
 }

 TEST(NetworkIsolationKeyTest, NonEmptyKey) {
   url::Origin origin = url::Origin::Create(GURL("http://a.test/"));
   NetworkIsolationKey key(origin, origin);
   EXPECT_TRUE(key.IsFullyPopulated());
   EXPECT_EQ(origin.Serialize(), key.ToString());
   EXPECT_FALSE(key.IsTransient());
   EXPECT_EQ("http://a.test", key.ToDebugString());
 }

 TEST(NetworkIsolationKeyTest, OpaqueOriginKey) {
   url::Origin origin_data =
       url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
   NetworkIsolationKey key(origin_data, origin_data);
   EXPECT_TRUE(key.IsFullyPopulated());
   EXPECT_EQ(std::string(), key.ToString());
   EXPECT_TRUE(key.IsTransient());

   // Create another opaque origin, and make sure it has a different debug
   // string.
   const auto kOriginNew = origin_data.DeriveNewOpaqueOrigin();
   EXPECT_NE(key.ToDebugString(),
             NetworkIsolationKey(kOriginNew, kOriginNew).ToDebugString());
 }

 TEST(NetworkIsolationKeyTest, Operators) {
   // These are in ascending order.
   const NetworkIsolationKey kKeys[] = {
       NetworkIsolationKey(),
       // Unique origins are still sorted by scheme, so data is before file, and
       // file before http.
       NetworkIsolationKey(
           url::Origin::Create(GURL("data:text/html,<body>Hello World</body>")),
           url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"))),
       NetworkIsolationKey(url::Origin::Create(GURL("file:///foo")),
                           url::Origin::Create(GURL("file:///foo"))),
       NetworkIsolationKey(url::Origin::Create(GURL("http://a.test/")),
                           url::Origin::Create(GURL("http://a.test/"))),
       NetworkIsolationKey(url::Origin::Create(GURL("http://b.test/")),
                           url::Origin::Create(GURL("http://b.test/"))),
       NetworkIsolationKey(url::Origin::Create(GURL("https://a.test/")),
                           url::Origin::Create(GURL("https://a.test/"))),
   };

   for (size_t first = 0; first < base::size(kKeys); ++first) {
     NetworkIsolationKey key1 = kKeys[first];
     SCOPED_TRACE(key1.ToDebugString());

     EXPECT_TRUE(key1 == key1);
     EXPECT_FALSE(key1 < key1);

     // Make sure that copying a key doesn't change the results of any operation.
     // This check is a bit more interesting with unique origins.
     NetworkIsolationKey key1_copy = key1;
     EXPECT_TRUE(key1 == key1_copy);
     EXPECT_FALSE(key1 < key1_copy);
     EXPECT_FALSE(key1_copy < key1);

     for (size_t second = first + 1; second < base::size(kKeys); ++second) {
       NetworkIsolationKey key2 = kKeys[second];
       SCOPED_TRACE(key2.ToDebugString());

       EXPECT_TRUE(key1 < key2);
       EXPECT_FALSE(key2 < key1);
       EXPECT_FALSE(key1 == key2);
       EXPECT_FALSE(key2 == key1);
     }
   }
 }

 TEST(NetworkIsolationKeyTest, UniqueOriginOperators) {
   const auto kOrigin1 =
       url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
   const auto kOrigin2 =
       url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
   NetworkIsolationKey key1(kOrigin1, kOrigin1);
   NetworkIsolationKey key2(kOrigin2, kOrigin2);

   EXPECT_TRUE(key1 == key1);
   EXPECT_TRUE(key2 == key2);

   // Creating copies shouldn't affect comparison result.
   EXPECT_TRUE(NetworkIsolationKey(key1) == NetworkIsolationKey(key1));
   EXPECT_TRUE(NetworkIsolationKey(key2) == NetworkIsolationKey(key2));

   EXPECT_FALSE(key1 == key2);
   EXPECT_FALSE(key2 == key1);

   // Order of Nonces isn't predictable, but they should have an ordering.
   EXPECT_TRUE(key1 < key2 || key2 < key1);
   EXPECT_TRUE(!(key1 < key2) || !(key2 < key1));
 }

 TEST(NetworkIsolationKeyTest, WithFrameOrigin) {
   const auto kOriginA = url::Origin::Create(GURL("http://a.test"));
   const auto kOriginB = url::Origin::Create(GURL("http://b.test"));
   NetworkIsolationKey key1(kOriginB, kOriginB);
   NetworkIsolationKey key2(kOriginB, kOriginA);
   EXPECT_TRUE(key2.IsFullyPopulated());
   EXPECT_FALSE(key2.IsTransient());
   EXPECT_EQ("http://b.test", key2.ToString());
   EXPECT_EQ("http://b.test", key2.ToDebugString());

   EXPECT_TRUE(key1 == key2);
   EXPECT_FALSE(key1 != key2);
   EXPECT_FALSE(key1 < key2);
   EXPECT_FALSE(key2 < key1);
 }

 TEST(NetworkIsolationKeyTest, OpaqueOriginKeyWithFrameOrigin) {
   url::Origin origin_data =
       url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));

   NetworkIsolationKey key1(url::Origin::Create(GURL("http://a.test")),
                            origin_data);
   EXPECT_TRUE(key1.IsFullyPopulated());
   EXPECT_FALSE(key1.IsTransient());
   EXPECT_EQ("http://a.test", key1.ToString());
   EXPECT_EQ("http://a.test", key1.ToDebugString());

   NetworkIsolationKey key2(origin_data,
                            url::Origin::Create(GURL("http://a.test")));
   EXPECT_TRUE(key2.IsFullyPopulated());
   EXPECT_TRUE(key2.IsTransient());
   EXPECT_EQ("", key2.ToString());
   EXPECT_EQ(origin_data.GetDebugString(), key2.ToDebugString());
   EXPECT_NE(origin_data.DeriveNewOpaqueOrigin().GetDebugString(),
             key2.ToDebugString());
 }

 TEST(NetworkIsolationKeyTest, ValueRoundTripEmpty) {
   const url::Origin kJunkOrigin =
       url::Origin::Create(GURL("data:text/html,junk"));

   // Convert empty key to value and back, expecting the same value.
   NetworkIsolationKey no_frame_origin_key;
   base::Value no_frame_origin_value;
   ASSERT_TRUE(no_frame_origin_key.ToValue(&no_frame_origin_value));

   // Fill initial value with junk data, to make sure it's overwritten.
   NetworkIsolationKey out_key(kJunkOrigin, kJunkOrigin);
   EXPECT_TRUE(NetworkIsolationKey::FromValue(no_frame_origin_value, &out_key));
   EXPECT_EQ(no_frame_origin_key, out_key);

   // Perform same checks when frame origins are enabled.

   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(
       net::features::kAppendFrameOriginToNetworkIsolationKey);

   NetworkIsolationKey frame_origin_key;
   base::Value frame_origin_value;
   ASSERT_TRUE(frame_origin_key.ToValue(&frame_origin_value));

   // Fill initial value with junk data, to make sure it's overwritten.
   out_key = NetworkIsolationKey(kJunkOrigin, kJunkOrigin);
   EXPECT_TRUE(NetworkIsolationKey::FromValue(frame_origin_value, &out_key));
   EXPECT_EQ(frame_origin_key, out_key);

   // The Values should also be the same in both cases.
   EXPECT_EQ(no_frame_origin_key, frame_origin_key);
 }

 TEST(NetworkIsolationKeyTest, ValueRoundTripNoFrameOrigin) {
   const url::Origin kJunkOrigin =
       url::Origin::Create(GURL("data:text/html,junk"));

   NetworkIsolationKey key1(url::Origin::Create(GURL("https://foo.test/")),
                            kJunkOrigin);
   base::Value value;
   ASSERT_TRUE(key1.ToValue(&value));

   // Fill initial value with junk data, to make sure it's overwritten.
   NetworkIsolationKey key2(kJunkOrigin, kJunkOrigin);
   EXPECT_TRUE(NetworkIsolationKey::FromValue(value, &key2));
   EXPECT_EQ(key1, key2);

   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(
       net::features::kAppendFrameOriginToNetworkIsolationKey);

   // Loading should fail when frame origins are enabled.
   EXPECT_FALSE(NetworkIsolationKey::FromValue(value, &key2));
 }

 TEST(NetworkIsolationKeyTest, ValueRoundTripFrameOrigin) {
   const url::Origin kJunkOrigin =
       url::Origin::Create(GURL("data:text/html,junk"));

   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(
       net::features::kAppendFrameOriginToNetworkIsolationKey);

   NetworkIsolationKey key1(url::Origin::Create(GURL("https://foo.test/")),
                            url::Origin::Create(GURL("https://foo.test/")));
   base::Value value;
   ASSERT_TRUE(key1.ToValue(&value));

   // Fill initial value with junk data, to make sure it's overwritten.
   NetworkIsolationKey key2(kJunkOrigin, kJunkOrigin);
   EXPECT_TRUE(NetworkIsolationKey::FromValue(value, &key2));
   EXPECT_EQ(key1, key2);

   feature_list.Reset();

   // Loading should fail when frame origins are disabled.
   EXPECT_FALSE(NetworkIsolationKey::FromValue(value, &key2));
 }

 TEST(NetworkIsolationKeyTest, ToValueTransientOrigin) {
   const url::Origin kTransientOrigin =
       url::Origin::Create(GURL("data:text/html,transient"));

   for (bool use_frame_origins : {false, true}) {
     SCOPED_TRACE(use_frame_origins);
     base::test::ScopedFeatureList feature_list;
     if (use_frame_origins) {
       feature_list.InitAndEnableFeature(
           net::features::kAppendFrameOriginToNetworkIsolationKey);
     }

     NetworkIsolationKey key1(kTransientOrigin, kTransientOrigin);
     EXPECT_TRUE(key1.IsTransient());
     base::Value value;
     EXPECT_FALSE(key1.ToValue(&value));
   }
 }

 TEST(NetworkIsolationKeyTest, FromValueBadData) {
   // Can't create these inline, since vector initialization lists require a
   // copy, and base::Value has no copy operator, only move.
   base::Value::ListStorage not_a_url_list;
   not_a_url_list.emplace_back(base::Value("not-a-url"));

   base::Value::ListStorage transient_origin_list;
   transient_origin_list.emplace_back(base::Value("data:text/html,transient"));

   base::Value::ListStorage too_many_origins_list;
   too_many_origins_list.emplace_back(base::Value("https://too/"));
   too_many_origins_list.emplace_back(base::Value("https://many/"));
   too_many_origins_list.emplace_back(base::Value("https://origins/"));

   const base::Value kTestCases[] = {
       base::Value(base::Value::Type::STRING),
       base::Value(base::Value::Type::DICTIONARY),
       base::Value(std::move(not_a_url_list)),
       base::Value(std::move(transient_origin_list)),
       base::Value(std::move(too_many_origins_list)),
   };

   for (bool use_frame_origins : {false, true}) {
     SCOPED_TRACE(use_frame_origins);
     base::test::ScopedFeatureList feature_list;
     if (use_frame_origins) {
       feature_list.InitAndEnableFeature(
           net::features::kAppendFrameOriginToNetworkIsolationKey);
     }

     for (const auto& test_case : kTestCases) {
       NetworkIsolationKey key;
       // Write the value on failure.
       EXPECT_FALSE(NetworkIsolationKey::FromValue(test_case, &key))
           << test_case;
     }
   }
 }

 class NetworkIsolationKeyWithFrameOriginTest : public testing::Test {
  public:
   NetworkIsolationKeyWithFrameOriginTest() {
     feature_list_.InitAndEnableFeature(
         net::features::kAppendFrameOriginToNetworkIsolationKey);
   }

  private:
   base::test::ScopedFeatureList feature_list_;
 };

 TEST_F(NetworkIsolationKeyWithFrameOriginTest, WithFrameOrigin) {
   NetworkIsolationKey key(url::Origin::Create(GURL("http://b.test")),
                           url::Origin::Create(GURL("http://a.test/")));
   EXPECT_TRUE(key.IsFullyPopulated());
   EXPECT_FALSE(key.IsTransient());
   EXPECT_EQ("http://b.test http://a.test", key.ToString());
   EXPECT_EQ("http://b.test http://a.test", key.ToDebugString());

   EXPECT_TRUE(key == key);
   EXPECT_FALSE(key != key);
   EXPECT_FALSE(key < key);
 }

 TEST_F(NetworkIsolationKeyWithFrameOriginTest, OpaqueOriginKey) {
   url::Origin origin_data =
       url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));

   NetworkIsolationKey key1(url::Origin::Create(GURL("http://a.test")),
                            origin_data);
   EXPECT_TRUE(key1.IsFullyPopulated());
   EXPECT_TRUE(key1.IsTransient());
   EXPECT_EQ("", key1.ToString());
   EXPECT_EQ("http://a.test " + origin_data.GetDebugString(),
             key1.ToDebugString());
   EXPECT_NE(
       "http://a.test " + origin_data.DeriveNewOpaqueOrigin().GetDebugString(),
       key1.ToDebugString());

   NetworkIsolationKey key2(origin_data,
                            url::Origin::Create(GURL("http://a.test")));
   EXPECT_TRUE(key2.IsFullyPopulated());
   EXPECT_TRUE(key2.IsTransient());
   EXPECT_EQ("", key2.ToString());
   EXPECT_EQ(origin_data.GetDebugString() + " http://a.test",
             key2.ToDebugString());
   EXPECT_NE(
       origin_data.DeriveNewOpaqueOrigin().GetDebugString() + " http://a.test",
       key2.ToDebugString());
 }

 TEST_F(NetworkIsolationKeyWithFrameOriginTest, OpaqueOriginKeyBoth) {
   url::Origin origin_data_1 =
       url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
   url::Origin origin_data_2 =
       url::Origin::Create(GURL("data:text/html,<body>Hello Universe</body>"));
   url::Origin origin_data_3 =
       url::Origin::Create(GURL("data:text/html,<body>Hello Cosmos</body>"));

   NetworkIsolationKey key1(origin_data_1, origin_data_2);
   NetworkIsolationKey key2(origin_data_1, origin_data_2);
   NetworkIsolationKey key3(origin_data_1, origin_data_3);

   // All the keys should be fully populated and transient.
   EXPECT_TRUE(key1.IsFullyPopulated());
   EXPECT_TRUE(key2.IsFullyPopulated());
   EXPECT_TRUE(key3.IsFullyPopulated());
   EXPECT_TRUE(key1.IsTransient());
   EXPECT_TRUE(key2.IsTransient());
   EXPECT_TRUE(key3.IsTransient());

   // Test the equality/comparisons of the various keys
   EXPECT_TRUE(key1 == key2);
   EXPECT_FALSE(key1 == key3);
   EXPECT_FALSE(key1 < key2 || key2 < key1);
   EXPECT_TRUE(key1 < key3 || key3 < key1);

   // Test the ToString and ToDebugString
   EXPECT_EQ(key1.ToDebugString(), key2.ToDebugString());
   EXPECT_NE(key1.ToDebugString(), key3.ToDebugString());
   EXPECT_EQ("", key1.ToString());
   EXPECT_EQ("", key2.ToString());
   EXPECT_EQ("", key3.ToString());
 }

 }  // namespace net
	// Copyright 2019 The Chromium Authors. All rights reserved.
	// Use of this source code is governed by a BSD-style license that can be
	// found in the LICENSE file.

	#include "net/base/network_isolation_key.h"

	#include "base/stl_util.h"
	#include "base/test/scoped_feature_list.h"
	#include "base/values.h"
	#include "net/base/features.h"
	#include "testing/gtest/include/gtest/gtest.h"
	#include "url/gurl.h"
	#include "url/origin.h"

	namespace net {

	TEST(NetworkIsolationKeyTest, EmptyKey) {
	NetworkIsolationKey key;
	EXPECT_FALSE(key.IsFullyPopulated());
	EXPECT_EQ(std::string(), key.ToString());
	EXPECT_TRUE(key.IsTransient());
	EXPECT_EQ("null", key.ToDebugString());
	}

	TEST(NetworkIsolationKeyTest, NonEmptyKey) {
	url::Origin origin = url::Origin::Create(GURL("http://a.test/"));
	NetworkIsolationKey key(origin, origin);
	EXPECT_TRUE(key.IsFullyPopulated());
	EXPECT_EQ(origin.Serialize(), key.ToString());
	EXPECT_FALSE(key.IsTransient());
	EXPECT_EQ("http://a.test", key.ToDebugString());
	}

	TEST(NetworkIsolationKeyTest, OpaqueOriginKey) {
	url::Origin origin_data =
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
	NetworkIsolationKey key(origin_data, origin_data);
	EXPECT_TRUE(key.IsFullyPopulated());
	EXPECT_EQ(std::string(), key.ToString());
	EXPECT_TRUE(key.IsTransient());

	// Create another opaque origin, and make sure it has a different debug
	// string.
	const auto kOriginNew = origin_data.DeriveNewOpaqueOrigin();
	EXPECT_NE(key.ToDebugString(),
	NetworkIsolationKey(kOriginNew, kOriginNew).ToDebugString());
	}

	TEST(NetworkIsolationKeyTest, Operators) {
	// These are in ascending order.
	const NetworkIsolationKey kKeys[] = {
	NetworkIsolationKey(),
	// Unique origins are still sorted by scheme, so data is before file, and
	// file before http.
	NetworkIsolationKey(
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>")),
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"))),
	NetworkIsolationKey(url::Origin::Create(GURL("file:///foo")),
	url::Origin::Create(GURL("file:///foo"))),
	NetworkIsolationKey(url::Origin::Create(GURL("http://a.test/")),
	url::Origin::Create(GURL("http://a.test/"))),
	NetworkIsolationKey(url::Origin::Create(GURL("http://b.test/")),
	url::Origin::Create(GURL("http://b.test/"))),
	NetworkIsolationKey(url::Origin::Create(GURL("https://a.test/")),
	url::Origin::Create(GURL("https://a.test/"))),
	};

	for (size_t first = 0; first < base::size(kKeys); ++first) {
	NetworkIsolationKey key1 = kKeys[first];
	SCOPED_TRACE(key1.ToDebugString());

	EXPECT_TRUE(key1 == key1);
	EXPECT_FALSE(key1 < key1);

	// Make sure that copying a key doesn't change the results of any operation.
	// This check is a bit more interesting with unique origins.
	NetworkIsolationKey key1_copy = key1;
	EXPECT_TRUE(key1 == key1_copy);
	EXPECT_FALSE(key1 < key1_copy);
	EXPECT_FALSE(key1_copy < key1);

	for (size_t second = first + 1; second < base::size(kKeys); ++second) {
	NetworkIsolationKey key2 = kKeys[second];
	SCOPED_TRACE(key2.ToDebugString());

	EXPECT_TRUE(key1 < key2);
	EXPECT_FALSE(key2 < key1);
	EXPECT_FALSE(key1 == key2);
	EXPECT_FALSE(key2 == key1);
	}
	}
	}

	TEST(NetworkIsolationKeyTest, UniqueOriginOperators) {
	const auto kOrigin1 =
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
	const auto kOrigin2 =
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
	NetworkIsolationKey key1(kOrigin1, kOrigin1);
	NetworkIsolationKey key2(kOrigin2, kOrigin2);

	EXPECT_TRUE(key1 == key1);
	EXPECT_TRUE(key2 == key2);

	// Creating copies shouldn't affect comparison result.
	EXPECT_TRUE(NetworkIsolationKey(key1) == NetworkIsolationKey(key1));
	EXPECT_TRUE(NetworkIsolationKey(key2) == NetworkIsolationKey(key2));

	EXPECT_FALSE(key1 == key2);
	EXPECT_FALSE(key2 == key1);

	// Order of Nonces isn't predictable, but they should have an ordering.
	EXPECT_TRUE(key1 < key2 \|\| key2 < key1);
	EXPECT_TRUE(!(key1 < key2) \|\| !(key2 < key1));
	}

	TEST(NetworkIsolationKeyTest, WithFrameOrigin) {
	const auto kOriginA = url::Origin::Create(GURL("http://a.test"));
	const auto kOriginB = url::Origin::Create(GURL("http://b.test"));
	NetworkIsolationKey key1(kOriginB, kOriginB);
	NetworkIsolationKey key2(kOriginB, kOriginA);
	EXPECT_TRUE(key2.IsFullyPopulated());
	EXPECT_FALSE(key2.IsTransient());
	EXPECT_EQ("http://b.test", key2.ToString());
	EXPECT_EQ("http://b.test", key2.ToDebugString());

	EXPECT_TRUE(key1 == key2);
	EXPECT_FALSE(key1 != key2);
	EXPECT_FALSE(key1 < key2);
	EXPECT_FALSE(key2 < key1);
	}

	TEST(NetworkIsolationKeyTest, OpaqueOriginKeyWithFrameOrigin) {
	url::Origin origin_data =
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));

	NetworkIsolationKey key1(url::Origin::Create(GURL("http://a.test")),
	origin_data);
	EXPECT_TRUE(key1.IsFullyPopulated());
	EXPECT_FALSE(key1.IsTransient());
	EXPECT_EQ("http://a.test", key1.ToString());
	EXPECT_EQ("http://a.test", key1.ToDebugString());

	NetworkIsolationKey key2(origin_data,
	url::Origin::Create(GURL("http://a.test")));
	EXPECT_TRUE(key2.IsFullyPopulated());
	EXPECT_TRUE(key2.IsTransient());
	EXPECT_EQ("", key2.ToString());
	EXPECT_EQ(origin_data.GetDebugString(), key2.ToDebugString());
	EXPECT_NE(origin_data.DeriveNewOpaqueOrigin().GetDebugString(),
	key2.ToDebugString());
	}

	TEST(NetworkIsolationKeyTest, ValueRoundTripEmpty) {
	const url::Origin kJunkOrigin =
	url::Origin::Create(GURL("data:text/html,junk"));

	// Convert empty key to value and back, expecting the same value.
	NetworkIsolationKey no_frame_origin_key;
	base::Value no_frame_origin_value;
	ASSERT_TRUE(no_frame_origin_key.ToValue(&no_frame_origin_value));

	// Fill initial value with junk data, to make sure it's overwritten.
	NetworkIsolationKey out_key(kJunkOrigin, kJunkOrigin);
	EXPECT_TRUE(NetworkIsolationKey::FromValue(no_frame_origin_value, &out_key));
	EXPECT_EQ(no_frame_origin_key, out_key);

	// Perform same checks when frame origins are enabled.

	base::test::ScopedFeatureList feature_list;
	feature_list.InitAndEnableFeature(
	net::features::kAppendFrameOriginToNetworkIsolationKey);

	NetworkIsolationKey frame_origin_key;
	base::Value frame_origin_value;
	ASSERT_TRUE(frame_origin_key.ToValue(&frame_origin_value));

	// Fill initial value with junk data, to make sure it's overwritten.
	out_key = NetworkIsolationKey(kJunkOrigin, kJunkOrigin);
	EXPECT_TRUE(NetworkIsolationKey::FromValue(frame_origin_value, &out_key));
	EXPECT_EQ(frame_origin_key, out_key);

	// The Values should also be the same in both cases.
	EXPECT_EQ(no_frame_origin_key, frame_origin_key);
	}

	TEST(NetworkIsolationKeyTest, ValueRoundTripNoFrameOrigin) {
	const url::Origin kJunkOrigin =
	url::Origin::Create(GURL("data:text/html,junk"));

	NetworkIsolationKey key1(url::Origin::Create(GURL("https://foo.test/")),
	kJunkOrigin);
	base::Value value;
	ASSERT_TRUE(key1.ToValue(&value));

	// Fill initial value with junk data, to make sure it's overwritten.
	NetworkIsolationKey key2(kJunkOrigin, kJunkOrigin);
	EXPECT_TRUE(NetworkIsolationKey::FromValue(value, &key2));
	EXPECT_EQ(key1, key2);

	base::test::ScopedFeatureList feature_list;
	feature_list.InitAndEnableFeature(
	net::features::kAppendFrameOriginToNetworkIsolationKey);

	// Loading should fail when frame origins are enabled.
	EXPECT_FALSE(NetworkIsolationKey::FromValue(value, &key2));
	}

	TEST(NetworkIsolationKeyTest, ValueRoundTripFrameOrigin) {
	const url::Origin kJunkOrigin =
	url::Origin::Create(GURL("data:text/html,junk"));

	base::test::ScopedFeatureList feature_list;
	feature_list.InitAndEnableFeature(
	net::features::kAppendFrameOriginToNetworkIsolationKey);

	NetworkIsolationKey key1(url::Origin::Create(GURL("https://foo.test/")),
	url::Origin::Create(GURL("https://foo.test/")));
	base::Value value;
	ASSERT_TRUE(key1.ToValue(&value));

	// Fill initial value with junk data, to make sure it's overwritten.
	NetworkIsolationKey key2(kJunkOrigin, kJunkOrigin);
	EXPECT_TRUE(NetworkIsolationKey::FromValue(value, &key2));
	EXPECT_EQ(key1, key2);

	feature_list.Reset();

	// Loading should fail when frame origins are disabled.
	EXPECT_FALSE(NetworkIsolationKey::FromValue(value, &key2));
	}

	TEST(NetworkIsolationKeyTest, ToValueTransientOrigin) {
	const url::Origin kTransientOrigin =
	url::Origin::Create(GURL("data:text/html,transient"));

	for (bool use_frame_origins : {false, true}) {
	SCOPED_TRACE(use_frame_origins);
	base::test::ScopedFeatureList feature_list;
	if (use_frame_origins) {
	feature_list.InitAndEnableFeature(
	net::features::kAppendFrameOriginToNetworkIsolationKey);
	}

	NetworkIsolationKey key1(kTransientOrigin, kTransientOrigin);
	EXPECT_TRUE(key1.IsTransient());
	base::Value value;
	EXPECT_FALSE(key1.ToValue(&value));
	}
	}

	TEST(NetworkIsolationKeyTest, FromValueBadData) {
	// Can't create these inline, since vector initialization lists require a
	// copy, and base::Value has no copy operator, only move.
	base::Value::ListStorage not_a_url_list;
	not_a_url_list.emplace_back(base::Value("not-a-url"));

	base::Value::ListStorage transient_origin_list;
	transient_origin_list.emplace_back(base::Value("data:text/html,transient"));

	base::Value::ListStorage too_many_origins_list;
	too_many_origins_list.emplace_back(base::Value("https://too/"));
	too_many_origins_list.emplace_back(base::Value("https://many/"));
	too_many_origins_list.emplace_back(base::Value("https://origins/"));

	const base::Value kTestCases[] = {
	base::Value(base::Value::Type::STRING),
	base::Value(base::Value::Type::DICTIONARY),
	base::Value(std::move(not_a_url_list)),
	base::Value(std::move(transient_origin_list)),
	base::Value(std::move(too_many_origins_list)),
	};

	for (bool use_frame_origins : {false, true}) {
	SCOPED_TRACE(use_frame_origins);
	base::test::ScopedFeatureList feature_list;
	if (use_frame_origins) {
	feature_list.InitAndEnableFeature(
	net::features::kAppendFrameOriginToNetworkIsolationKey);
	}

	for (const auto& test_case : kTestCases) {
	NetworkIsolationKey key;
	// Write the value on failure.
	EXPECT_FALSE(NetworkIsolationKey::FromValue(test_case, &key))
	<< test_case;
	}
	}
	}

	class NetworkIsolationKeyWithFrameOriginTest : public testing::Test {
	public:
	NetworkIsolationKeyWithFrameOriginTest() {
	feature_list_.InitAndEnableFeature(
	net::features::kAppendFrameOriginToNetworkIsolationKey);
	}

	private:
	base::test::ScopedFeatureList feature_list_;
	};

	TEST_F(NetworkIsolationKeyWithFrameOriginTest, WithFrameOrigin) {
	NetworkIsolationKey key(url::Origin::Create(GURL("http://b.test")),
	url::Origin::Create(GURL("http://a.test/")));
	EXPECT_TRUE(key.IsFullyPopulated());
	EXPECT_FALSE(key.IsTransient());
	EXPECT_EQ("http://b.test http://a.test", key.ToString());
	EXPECT_EQ("http://b.test http://a.test", key.ToDebugString());

	EXPECT_TRUE(key == key);
	EXPECT_FALSE(key != key);
	EXPECT_FALSE(key < key);
	}

	TEST_F(NetworkIsolationKeyWithFrameOriginTest, OpaqueOriginKey) {
	url::Origin origin_data =
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));

	NetworkIsolationKey key1(url::Origin::Create(GURL("http://a.test")),
	origin_data);
	EXPECT_TRUE(key1.IsFullyPopulated());
	EXPECT_TRUE(key1.IsTransient());
	EXPECT_EQ("", key1.ToString());
	EXPECT_EQ("http://a.test " + origin_data.GetDebugString(),
	key1.ToDebugString());
	EXPECT_NE(
	"http://a.test " + origin_data.DeriveNewOpaqueOrigin().GetDebugString(),
	key1.ToDebugString());

	NetworkIsolationKey key2(origin_data,
	url::Origin::Create(GURL("http://a.test")));
	EXPECT_TRUE(key2.IsFullyPopulated());
	EXPECT_TRUE(key2.IsTransient());
	EXPECT_EQ("", key2.ToString());
	EXPECT_EQ(origin_data.GetDebugString() + " http://a.test",
	key2.ToDebugString());
	EXPECT_NE(
	origin_data.DeriveNewOpaqueOrigin().GetDebugString() + " http://a.test",
	key2.ToDebugString());
	}

	TEST_F(NetworkIsolationKeyWithFrameOriginTest, OpaqueOriginKeyBoth) {
	url::Origin origin_data_1 =
	url::Origin::Create(GURL("data:text/html,<body>Hello World</body>"));
	url::Origin origin_data_2 =
	url::Origin::Create(GURL("data:text/html,<body>Hello Universe</body>"));
	url::Origin origin_data_3 =
	url::Origin::Create(GURL("data:text/html,<body>Hello Cosmos</body>"));

	NetworkIsolationKey key1(origin_data_1, origin_data_2);
	NetworkIsolationKey key2(origin_data_1, origin_data_2);
	NetworkIsolationKey key3(origin_data_1, origin_data_3);

	// All the keys should be fully populated and transient.
	EXPECT_TRUE(key1.IsFullyPopulated());
	EXPECT_TRUE(key2.IsFullyPopulated());
	EXPECT_TRUE(key3.IsFullyPopulated());
	EXPECT_TRUE(key1.IsTransient());
	EXPECT_TRUE(key2.IsTransient());
	EXPECT_TRUE(key3.IsTransient());

	// Test the equality/comparisons of the various keys
	EXPECT_TRUE(key1 == key2);
	EXPECT_FALSE(key1 == key3);
	EXPECT_FALSE(key1 < key2 \|\| key2 < key1);
	EXPECT_TRUE(key1 < key3 \|\| key3 < key1);

	// Test the ToString and ToDebugString
	EXPECT_EQ(key1.ToDebugString(), key2.ToDebugString());
	EXPECT_NE(key1.ToDebugString(), key3.ToDebugString());
	EXPECT_EQ("", key1.ToString());
	EXPECT_EQ("", key2.ToString());
	EXPECT_EQ("", key3.ToString());
	}

	} // namespace net