Google Git
Sign in
chromium / chromium / src / e40c631a5f311d449e8c6e136f0d70e5d548b987
commite40c631a5f311d449e8c6e136f0d70e5d548b987[log] [tgz]
authorTommy C. Li <tommycli@chromium.org>Tue Oct 16 00:59:06 2018
committerCommit Bot <commit-bot@chromium.org>Tue Oct 16 00:59:06 2018
tree79bf4b184812004d296139a2a4312a68a581ce1f
parent6e5fd74284d522dda27807f4536fdfa50bb4cc01 [diff]
Downloads: After 100 numerically deduplicated files, try timestamp

After deduplicating 100 filenames,
i.e. foo.jpg, foo (1).jpg, ... foo (100).jpg, Chrome will stop trying.

On Desktop this is acceptable, as the user gets a prompt to choose
a filename.

On Android, this is really bad, because there is no prompt to choose
an alternate filename, and the download just silently fails.

This CL starts using a timestamp after 100, and creates filenames in
the ISO 8601 format, like: foo - 2018-10-11T21:55:47.392Z.jpg

Bug: 135428
Change-Id: I13748110171f799f58c8ddf27f22eebc97149c09
Reviewed-on: https://chromium-review.googlesource.com/c/1278137
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599802}
2 files changed
tree: 79bf4b184812004d296139a2a4312a68a581ce1f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .