Google Git
Sign in
chromium / chromium / src / e4e1aa3603cd167f2f132936575c09a6a8bedb61
commite4e1aa3603cd167f2f132936575c09a6a8bedb61[log] [tgz]
authorDavid Bokan <bokan@chromium.org>Tue Feb 13 15:23:28 2018
committerCommit Bot <commit-bot@chromium.org>Tue Feb 13 15:23:28 2018
tree734363cd2e1a646dcb8c4b9e97cf398fe9cb5845
parentfe64540e01311889d266c94de15b594e3e0f21cc [diff]
Add a scrolling test for find-in-page

Turning on root-layer-scrolling caused find in page to break in Android
but wasn't turned up by tests. This CL adds a test to fill the gap. The
regression was incidentally fixed in r535827.

Also update TextFinder to use AbsoluteToRootFrame rather than
ContentsToRootFrame. The two are equivalent but I'd like to eventually
remove the Contents nomenclature since it can be easily confused for
being relative to the document origin.

This CL has no functional changes.

Bug: 810067
Change-Id: Idec7335f17e45184467ea14e403504efe7f9771c
Reviewed-on: https://chromium-review.googlesource.com/912510
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536359}
3 files changed
tree: 734363cd2e1a646dcb8c4b9e97cf398fe9cb5845
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .