Google Git
Sign in
chromium / chromium / src / e63f4b0b18411d0ee68c42367f44109bb615b51b
commite63f4b0b18411d0ee68c42367f44109bb615b51b[log] [tgz]
authorJames Cook <jamescook@chromium.org>Mon Jun 02 20:19:27 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 02 20:19:27 2025
treeffbfa08577971bec3448de361d62d3b387a47324
parent58245d7ab6c53e4ad3e4fc658081cee581f943f9 [diff]
extensions: Create extension pref value store on desktop Android startup

Desktop Android supports extensions and therefore needs an instance of
ExtensionPrefValueStore in its PrefService. However, desktop Android
uses the "StartupData" code path during startup and profile
initialization. StartupData does not have a Profile object instance, so
it skips creating the extension pref value store when it creates the
initial PrefService. See here:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/startup_data.cc;drc=efce54025758dc9d4f370c0269b332cb0d67474b;l=239

Once the Profile is created we can initialize the extension pref value
store like we do on Win/Mac/Linux. However, we need to override the
value store in the existing pref service, like we do for the command
line value store.

A followup CL porting an extension API to desktop Android relies on
having a valid value store and will provide coverage of these code
paths.

Bug: 421235963
Change-Id: I4b0712f177841ec449a63264568de4fab1071522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6604299
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1468313}
5 files changed
tree: ffbfa08577971bec3448de361d62d3b387a47324
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.