Google Git
Sign in
chromium / chromium / src / 2473970780e9db35a133969b7de2a40597cc5797
commit2473970780e9db35a133969b7de2a40597cc5797[log] [tgz]
authorPeter Boström <pbos@chromium.org>Tue Dec 03 21:01:43 2019
committerCommit Bot <commit-bot@chromium.org>Tue Dec 03 21:01:43 2019
treec32a5d346650f74ea7b8a868a39e9470422cc6ac
parent6517b4884e5863dae5cd71783a4e12dfd45ef7f4 [diff]
Prevent double focus effect in IconLabelBubbleView

IconLabelBubbleView::AnimationEnded used to call
GetInkDrop()->SetShowHighlightOnFocus(true) to restore the original
InkDrop highlight state before this change. This is incorrect as the
initial highlight focus depends on the presence of a focus ring.

This changes the call to restore highlight-on-focus based on the
presence of a focus ring instead of unconditionally highlighting.

Bug: chromium:1025152
Change-Id: I5e6d563bc012a16a5bf4a63404375c4d4d1418e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949034
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721156}
1 file changed
tree: c32a5d346650f74ea7b8a868a39e9470422cc6ac
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .