commit | e6f739058a6e813d2b2c5d8bf1c218614981780b | [log] [tgz] |
---|---|---|
author | Dan Beam <dbeam@chromium.org> | Wed Feb 06 02:07:26 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 06 02:07:26 2019 |
tree | 3a8d251412a577e7f8ebed6ddf8f5f689b4aa860 | |
parent | 36dd9287b6f422477d0674386b2545b0093bdab7 [diff] |
WebUI Dark Mode: fix user manager shared styles scope Dark mode overrides of shared variables weren't working: :root {...} :host-context([dark]) {...} After much headbashing, I figured out Polymer was magically rewriting the first (:root) rule to: :host > * {...} inside custom elements only. https://github.com/Polymer/polymer/commit/fea64b9b6a75bb39b7644fdfdd56e1224f43bf3d So I changed :root to :host > *, which broke the copious amounts of styled light DOM the user manager uses (it's not in Shadow DOM so :host doesn't match). So instead, let's avoid :root and just use: html, :host {...} html[dark], :host-context([dark]) {...} R=hcarmona@chromium.org BUG=928674 Change-Id: I262572215e7f481b44d9a4af20645b06a2480041 Reviewed-on: https://chromium-review.googlesource.com/c/1455274 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#629421}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .