commit | e9068fe5acec0c79976408c25aed916cc5891467 | [log] [tgz] |
---|---|---|
author | Gyuyoung Kim <gyuyoung@igalia.com> | Fri Feb 22 14:26:26 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 14:26:26 2019 |
tree | 4416964909e9ca4b7e367720dfa3538dd94eea09 | |
parent | cb736f23701a1284cc2266dd14170e1c57d2766e [diff] |
BlinkMemoryMgt: Annotate the 2 classes of xml and xmlhttprequest with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/xml and //blink/renderer/core/xmlhttprequest have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of XMLParserContent class, it makes sense to use USING_FAST_MALLOC because it has been used with scoped_refptr<> In DeferredEvent class case, it makes sense to use DISALLOW_NEW because it has been used by a member variable with a reference. Bug: 919389 Change-Id: I18da5a1078b91caec8ad69c338ef874c9395f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/1482280 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#634651}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .