tree 0016d63da5db9b4ca117702d220e23574abd6100
parent 4b891e849b02d2165124d0f058bf445c5e8fbd3e
author Carlos IL <carlosil@chromium.org> 1650651610 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1650651610 +0000

Remove WaitForInterstitial method in tests

This method is no longer required with committed interstitials (it now
only asserts an interstitial is shown, then runs
WaitForRenderFrameReady), since the regular navigation wait works for
committed interstitials. It seems the WaitForRenderFrameReady was also
causing flaky tests due to timeouts (e.g. crbug.com/1287661) if it
happened to be called after the RenderFrameReady event happened.
This replaces the method with an assertion that an interstitial is
shown in all callsites (except where an assertion would be redundant
due to an existing similar assertion).

Bug: 1287661
Change-Id: Ie54c5b63634215c1f7bfb07c92bfdfb51e9913ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3596203
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995272}