commit | eae61dc22e2d0ce54f9a373916dd39c224c6952f | [log] [tgz] |
---|---|---|
author | Gyuyoung Kim <gyuyoung@igalia.com> | Mon Feb 25 13:26:27 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 25 13:26:27 2019 |
tree | aa1a3a14a698cebd0912f0842ec54d63f4c63ff7 | |
parent | 6b75207493cb1c00f5da8690ac0bef4cbb022b33 [diff] |
BlinkMemoryMgt: Annotate GamepadStateCompareResult and GamepadComparisons with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/modules/gamepad have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of GamepadStateCompareResult class, it makes sense to use STACK_ALLOCATED because it has been used only in functions. In GamepadComparisons class case, it makes sense to use STATIC_ONLY because it only has static functions. Bug: 919389 Change-Id: Ia159dedc96494faa2642385a6106b260d2a5530b Reviewed-on: https://chromium-review.googlesource.com/c/1484394 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#635089}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .