tree 06a18eef651f81cec76463f37b1262bde3feac48
parent 349059c0123b8558f097e0dd598512adfac87782
author Anthi Orfanou <anthie@google.com> 1710243675 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1710243675 +0000

Reland "Perform extension parent approval migration on Desktop"

This reverts commit 6716444483ab42670ebfd6d7d51653242a3477d5.

Reason for revert: The reason behind the failing test in
6716444483ab42670ebfd6d7d51653242a3477d5 is that the bool
is_active_policy_for_supervised_users_ is read in methods
invoked by the class' constructor, before it is initialized
in `ActivateManagementPolicyAndUpdateRegistration`.
This is part of the existing code, the test just happened
to catch this.

Assigning a default, false value, in the constructor fixes
this. This is the only difference to the original commit.

Original change's description:
> Revert "Perform extension parent approval migration on Desktop"
>
> This reverts commit 8baaf5ef045a0742ff377b5673bda909ab3ae267.
>
> Reason for revert: Causing a Linux MSAN bot to fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/41702/overview
>
> It appears to be a UAF caused at some point in SupervisedUserExtensionsManager::RefreshApprovedExtensionsFromPrefs()
>
> Original change's description:
> > Perform extension parent approval migration on Desktop
> >
> > When the feature 'EnableSupervisedUserSkipParentApprovalToInstallExtensions'
> > become enabled, the existing extensions on Desktop (Win/Mac/Linux) platforms are marked as locally-parent approved on that device, in a local preference, with a single-run migration.
> > The migration does not apply to ChromeOS platforms
> > where parental controls on extensions are already in place.
> >
> > Bug: b/321240030
> > Change-Id: I929fcb10b8f855602d6852b8195cedea477ed8b7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321729
> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
> > Commit-Queue: Anthi Orfanou <anthie@google.com>
> > Reviewed-by: Courtney Wong <courtneywong@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1270253}
>
> Bug: b/321240030
> Change-Id: Iaae5a62a1e6c8ec03e4247ff1970afc9b2a0fca5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5356979
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Darryl James <dljames@chromium.org>
> Commit-Queue: Darryl James <dljames@chromium.org>
> Owners-Override: Darryl James <dljames@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1270458}

Bug: b/321240030
Change-Id: If93a2a92fb0ddf8dd62135526b7e8515000182c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5358318
Commit-Queue: Anthi Orfanou <anthie@google.com>
Reviewed-by: James Lee <ljjlee@google.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271469}