commit | ec31e7a82f0a08d1aae9f89c65a10053c8c3e9ca | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Mar 26 08:40:57 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 26 08:40:57 2019 |
tree | 63b05b9cbe92831a8e156ae1a570c4ec88a4a406 | |
parent | ad02bd108e77d07b652d1129a3fed939b21d4385 [diff] |
Make blink's mojo geometry types depend publicly on the struct_traits Generated code that use the mojo geometry types will end up including geometry_struct_traits.h and for that to be allowed by the build system, the dependency in the typemap needs to be public. An example (of about 100) error: ERROR at //out/Default/gen/device/vr/public/mojom/isolated_xr_service.mojom-blink-test-utils.cc:33:11: Can't include this header from here. ^---------------------------------------------------------------- The target: //device/vr/public/mojom:mojom_blink is including a file from the target: //third_party/blink/renderer/platform/mojo:geometry_struct_traits It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //device/vr/public/mojom:mojom_blink --> //ui/gfx/geometry/mojo:mojo_blink --[private]--> //third_party/blink/renderer/platform/mojo:geometry_struct_traits Bug: 938893 Change-Id: I2114034805ee2e55a8c98e98c22fe8233ac9fd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538418 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644225}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .