blob: eecfdbd9aa067f912c0d1c6feb6217b5fb6efa8a [file] [log] [blame]
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/browser/frame_host/render_frame_host_manager.h"
#include <stddef.h>
#include <algorithm>
#include <string>
#include <unordered_set>
#include <utility>
#include <vector>
#include "base/command_line.h"
#include "base/containers/adapters.h"
#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/stl_util.h"
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
#include "content/browser/child_process_security_policy_impl.h"
#include "content/browser/devtools/render_frame_devtools_agent_host.h"
#include "content/browser/frame_host/debug_urls.h"
#include "content/browser/frame_host/frame_navigation_entry.h"
#include "content/browser/frame_host/interstitial_page_impl.h"
#include "content/browser/frame_host/navigation_controller_impl.h"
#include "content/browser/frame_host/navigation_entry_impl.h"
#include "content/browser/frame_host/navigation_handle_impl.h"
#include "content/browser/frame_host/navigation_request.h"
#include "content/browser/frame_host/navigator.h"
#include "content/browser/frame_host/render_frame_host_factory.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/frame_host/render_frame_proxy_host.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_view_host_factory.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/site_instance_impl.h"
#include "content/browser/webui/web_ui_controller_factory_registry.h"
#include "content/common/frame_messages.h"
#include "content/common/frame_owner_properties.h"
#include "content/common/page_messages.h"
#include "content/common/unfreezable_frame_messages.h"
#include "content/common/view_messages.h"
#include "content/public/browser/child_process_security_policy.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/render_process_host_observer.h"
#include "content/public/browser/render_widget_host_iterator.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/site_isolation_policy.h"
#include "content/public/common/child_process_host.h"
#include "content/public/common/content_features.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/mime_handler_view_mode.h"
#include "content/public/common/navigation_policy.h"
#include "content/public/common/referrer.h"
#include "content/public/common/url_constants.h"
#include "content/public/common/url_utils.h"
#if defined(OS_MACOSX)
#include "ui/gfx/mac/scoped_cocoa_disable_screen_updates.h"
#endif // defined(OS_MACOSX)
namespace content {
namespace {
bool IsDataOrAbout(const GURL& url) {
return url.IsAboutSrcdoc() || url.IsAboutBlank() ||
url.scheme() == url::kDataScheme;
// Helper function to determine whether a navigation from |current_rfh| to
// |dest_url| should swap BrowsingInstances to ensure that |dest_url| ends up
// in a dedicated process. This is the case when |dest_url| has an origin that
// was just isolated dynamically, where leaving the navigation in the current
// BrowsingInstance would leave |dest_url| without a dedicated process, since
// dynamic origin isolation applies only to future BrowsingInstances. In the
// common case where |current_rfh| is a main frame, and there are no scripting
// references to it from other windows, it is safe to swap BrowsingInstances to
// ensure the new isolated origin takes effect. Note that this applies even to
// same-site navigations, as well as to renderer-initiated navigations.
bool ShouldSwapBrowsingInstancesForDynamicIsolation(
RenderFrameHostImpl* current_rfh,
const GURL& dest_url) {
// Only main frames are eligible to swap BrowsingInstances.
if (!current_rfh->frame_tree_node()->IsMainFrame())
return false;
// Skip cases when there are other windows that might script this one.
SiteInstanceImpl* current_instance = current_rfh->GetSiteInstance();
if (current_instance->GetRelatedActiveContentsCount() > 1u)
return false;
// Check whether |dest_url| would require a dedicated process if we left it
// in the current BrowsingInstance. If so, there's no need to swap
// BrowsingInstances.
if (SiteInstanceImpl::DoesSiteRequireDedicatedProcess(
current_instance->GetIsolationContext(), dest_url)) {
return false;
// Finally, check whether |dest_url| would require a dedicated process if we
// were to swap to a fresh BrowsingInstance. To check this, use a new
// IsolationContext, rather than current_instance->GetIsolationContext().
IsolationContext future_isolation_context(
return SiteInstanceImpl::DoesSiteRequireDedicatedProcess(
future_isolation_context, dest_url);
bool ShouldProactivelySwapBrowsingInstance(RenderFrameHostImpl* current_rfh,
const GURL& dest_url) {
if (!IsProactivelySwapBrowsingInstanceEnabled())
return false;
// Only main frames are eligible to swap BrowsingInstances.
if (!current_rfh->frame_tree_node()->IsMainFrame())
return false;
// Skip cases when there are other windows that might script this one.
SiteInstanceImpl* current_instance = current_rfh->GetSiteInstance();
if (current_instance->GetRelatedActiveContentsCount() > 1u)
return false;
// "about:blank" and chrome-native-URL do not "use" a SiteInstance. This
// allows the SiteInstance to be reused cross-site. Starting a new
// BrowsingInstance would prevent the SiteInstance to be reused, that's why
// this case is excluded here.
if (!current_instance->HasSite())
return false;
// Exclude non http(s) schemes. Some tests don't expect navigations to
// data-URL or to about:blank to switch to a different BrowsingInstance.
const GURL& current_url = current_rfh->GetLastCommittedURL();
if (!current_url.SchemeIsHTTPOrHTTPS() || !dest_url.SchemeIsHTTPOrHTTPS())
return false;
// Nothing prevents two pages with the same website to live in different
// BrowsingInstance. However many tests are making this assumption. The scope
// of ProactivelySwapBrowsingInstance experiment doesn't include them. The
// cost of getting a new process on same-site navigation would (probably?) be
// too high.
if (SiteInstanceImpl::IsSameWebSite(current_instance->GetIsolationContext(),
current_url, dest_url, true)) {
return false;
return true;
} // namespace
RenderFrameHostManager::RenderFrameHostManager(FrameTreeNode* frame_tree_node,
Delegate* delegate)
: frame_tree_node_(frame_tree_node), delegate_(delegate) {
RenderFrameHostManager::~RenderFrameHostManager() {
// Delete any RenderFrameProxyHosts. It is important to delete those prior to
// deleting the current RenderFrameHost, since the CrossProcessFrameConnector
// (owned by RenderFrameProxyHost) points to the RenderWidgetHostView
// associated with the current RenderFrameHost and uses it during its
// destructor.
// We should always have a current RenderFrameHost except in some tests.
void RenderFrameHostManager::Init(SiteInstance* site_instance,
int32_t view_routing_id,
int32_t frame_routing_id,
int32_t widget_routing_id,
bool renderer_initiated_creation) {
SetRenderFrameHost(CreateRenderFrameHost(site_instance, view_routing_id,
frame_routing_id, widget_routing_id,
// Notify the delegate of the creation of the current RenderFrameHost.
// Do this only for subframes, as the main frame case is taken care of by
// WebContentsImpl::Init.
if (!frame_tree_node_->IsMainFrame()) {
nullptr, render_frame_host_.get(), false);
RenderViewHostImpl* RenderFrameHostManager::current_host() const {
if (!render_frame_host_)
return nullptr;
return render_frame_host_->render_view_host();
WebUIImpl* RenderFrameHostManager::GetNavigatingWebUI() const {
if (speculative_render_frame_host_)
return speculative_render_frame_host_->web_ui();
return render_frame_host_->pending_web_ui();
RenderWidgetHostView* RenderFrameHostManager::GetRenderWidgetHostView() const {
if (delegate_->GetInterstitialForRenderManager())
return delegate_->GetInterstitialForRenderManager()->GetView();
if (render_frame_host_)
return render_frame_host_->GetView();
return nullptr;
bool RenderFrameHostManager::IsMainFrameForInnerDelegate() {
return frame_tree_node_->IsMainFrame() &&
delegate_->GetOuterDelegateFrameTreeNodeId() !=
FrameTreeNode* RenderFrameHostManager::GetOuterDelegateNode() {
int outer_contents_frame_tree_node_id =
return FrameTreeNode::GloballyFindByID(outer_contents_frame_tree_node_id);
RenderFrameProxyHost* RenderFrameHostManager::GetProxyToParent() {
if (frame_tree_node_->IsMainFrame())
return nullptr;
return GetRenderFrameProxyHost(frame_tree_node_->parent()
RenderFrameProxyHost* RenderFrameHostManager::GetProxyToOuterDelegate() {
// Only the main frame should be able to reach the outer WebContents.
int outer_contents_frame_tree_node_id =
FrameTreeNode* outer_contents_frame_tree_node =
if (!outer_contents_frame_tree_node ||
!outer_contents_frame_tree_node->parent()) {
return nullptr;
return GetRenderFrameProxyHost(outer_contents_frame_tree_node->parent()
void RenderFrameHostManager::RemoveOuterDelegateFrame() {
// Removing the outer delegate frame will destroy the inner WebContents. This
// should only be called on the main frame.
FrameTreeNode* outer_delegate_frame_tree_node =
void RenderFrameHostManager::Stop() {
// A loading speculative RenderFrameHost should also stop.
if (speculative_render_frame_host_ &&
speculative_render_frame_host_->is_loading()) {
new FrameMsg_Stop(speculative_render_frame_host_->GetRoutingID()));
void RenderFrameHostManager::SetIsLoading(bool is_loading) {
void RenderFrameHostManager::OnBeforeUnloadACK(
bool proceed,
const base::TimeTicks& proceed_time) {
// If beforeunload was dispatched as part of preparing this frame for
// attaching an inner delegate, continue attaching now.
if (is_attaching_inner_delegate()) {
if (proceed) {
} else {
NotifyPrepareForInnerDelegateAttachComplete(false /* success */);
bool proceed_to_fire_unload = false;
delegate_->BeforeUnloadFiredFromRenderManager(proceed, proceed_time,
if (proceed_to_fire_unload) {
// If we're about to close the tab and there's a speculative RFH, cancel it.
// Otherwise, if the navigation in the speculative RFH completes before the
// close in the current RFH, we'll lose the tab close.
if (speculative_render_frame_host_)
void RenderFrameHostManager::DidNavigateFrame(
RenderFrameHostImpl* render_frame_host,
bool was_caused_by_user_gesture,
bool is_same_document_navigation) {
CommitPendingIfNecessary(render_frame_host, was_caused_by_user_gesture,
// Make sure any dynamic changes to this frame's sandbox flags and feature
// policy that were made prior to navigation take effect. This should only
// happen for cross-document navigations.
if (!is_same_document_navigation)
void RenderFrameHostManager::CommitPendingIfNecessary(
RenderFrameHostImpl* render_frame_host,
bool was_caused_by_user_gesture,
bool is_same_document_navigation) {
if (!speculative_render_frame_host_) {
// There's no speculative RenderFrameHost so it must be that the current
// renderer process completed a navigation.
// TODO(danakj): Make this a CHECK and stop handling it. Then make it a
// DCHECK when we're sure.
DCHECK_EQ(render_frame_host_.get(), render_frame_host);
if (render_frame_host != render_frame_host_.get())
if (render_frame_host == speculative_render_frame_host_.get()) {
// A cross-process navigation completed, so show the new renderer. If a
// same-process navigation is also ongoing, it will be canceled when the
// speculative RenderFrameHost replaces the current one in the commit call
// below.
frame_tree_node_->ResetNavigationRequest(false, true);
// A same-process navigation committed. A cross-process navigation may also
// be ongoing.
// If the current RenderFrameHost has a pending WebUI it must be committed.
if (render_frame_host_->pending_web_ui())
// A navigation in the original process has taken place, while a
// cross-process navigation is ongoing. This should cancel the ongoing
// cross-process navigation if the commit is cross-document and has a user
// gesture (since the user might have clicked on a new link while waiting for
// a slow navigation), but it should not cancel it for same-document
// navigations (which might happen as bookkeeping) or when there is no user
// gesture (which might abusively try to prevent the user from leaving).
// See and for examples.
if (speculative_render_frame_host_ && !is_same_document_navigation &&
was_caused_by_user_gesture) {
frame_tree_node_->ResetNavigationRequest(false, true);
if (render_frame_host_->is_local_root() && render_frame_host_->GetView()) {
// RenderFrames are created with a hidden RenderWidgetHost. When
// navigation finishes, we show it if the delegate is shown. CommitPending()
// takes care of this in the cross-process case, as well as other cases
// where a RenderFrameHost is swapped in.
if (!delegate_->IsHidden())
void RenderFrameHostManager::DidChangeOpener(
int opener_routing_id,
SiteInstance* source_site_instance) {
FrameTreeNode* opener = nullptr;
if (opener_routing_id != MSG_ROUTING_NONE) {
RenderFrameHostImpl* opener_rfhi = RenderFrameHostImpl::FromID(
source_site_instance->GetProcess()->GetID(), opener_routing_id);
// If |opener_rfhi| is null, the opener RFH has already disappeared. In
// this case, clear the opener rather than keeping the old opener around.
if (opener_rfhi)
opener = opener_rfhi->frame_tree_node();
if (frame_tree_node_->opener() == opener)
for (const auto& pair : proxy_hosts_) {
if (pair.second->GetSiteInstance() == source_site_instance)
if (render_frame_host_->GetSiteInstance() != source_site_instance)
// Notify the speculative RenderFrameHosts as well. This is necessary in case
// a process swap has started while the message was in flight.
if (speculative_render_frame_host_ &&
speculative_render_frame_host_->GetSiteInstance() !=
source_site_instance) {
void RenderFrameHostManager::CommitPendingFramePolicy() {
// Return early if there were no pending updates to sandbox flags or container
// policy.
if (!frame_tree_node_->CommitPendingFramePolicy())
// Policy updates can only happen when the frame has a parent.
// There should be no children of this frame; any policy changes should only
// happen on navigation commit.
// Notify all of the frame's proxies about updated policies, excluding
// the parent process since it already knows the latest state.
SiteInstance* parent_site_instance =
for (const auto& pair : proxy_hosts_) {
if (pair.second->GetSiteInstance() != parent_site_instance) {
pair.second->Send(new FrameMsg_DidUpdateFramePolicy(
void RenderFrameHostManager::OnDidSetFramePolicyHeaders() {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_DidSetFramePolicyHeaders(
pair.second->GetRoutingID(), frame_tree_node_->active_sandbox_flags(),
void RenderFrameHostManager::SwapOutOldFrame(
std::unique_ptr<RenderFrameHostImpl> old_render_frame_host) {
TRACE_EVENT1("navigation", "RenderFrameHostManager::SwapOutOldFrame",
"FrameTreeNode id", frame_tree_node_->frame_tree_node_id());
// Tell the renderer to suppress any further modal dialogs so that we can swap
// it out. This must be done before canceling any current dialog, in case
// there is a loop creating additional dialogs.
// TODO(arthursonzogni): Undo this for documents restored from the
// BackForwardCache.
// Now close any modal dialogs that would prevent us from swapping out. This
// must be done separately from SwapOut, so that the ScopedPageLoadDeferrer is
// no longer on the stack when we send the SwapOut message.
// If the old RFH is not live, just return as there is no further work to do.
// It will be deleted and there will be no proxy created.
if (!old_render_frame_host->IsRenderFrameLive())
// Reset any NavigationRequest in the RenderFrameHost. A swapped out
// RenderFrameHost should not be trying to commit a navigation.
// Record the metrics about the state of the old main frame at the moment when
// we navigate away from it as it matters for whether the page is eligible for
// being put into back-forward cache.
// This covers the cross-process navigation case and the same-process case is
// handled in RenderFrameHostImpl::CommitNavigation, so the subframe state
// can be captured before the frame navigates away.
// TODO(altimin, Remove this logic after we are done with
// implementing back-forward cache.
if (!old_render_frame_host->GetParent()) {
if (NavigationEntryImpl* last_committed_entry =
.GetLastCommittedEntry()) {
if (last_committed_entry->back_forward_cache_metrics()) {
// BackForwardCache:
// If the old RenderFrameHost can be stored in the BackForwardCache, return
// early without swapping out and running unload handlers, as the document may
// be restored later.
BackForwardCache& back_forward_cache =
if (back_forward_cache.CanStoreDocument(old_render_frame_host.get())) {
// Create a replacement proxy for the old RenderFrameHost. (There should not
// be one yet.) This is done even if there are no active frames besides this
// one to simplify cleanup logic on the renderer side (see
// for motivation).
RenderFrameProxyHost* proxy =
// Tell the old RenderFrameHost to swap out and be replaced by the proxy.
old_render_frame_host->SwapOut(proxy, true);
// |old_render_frame_host| will be deleted when its SwapOut ACK is received,
// or when the timer times out, or when the RFHM itself is deleted (whichever
// comes first).
void RenderFrameHostManager::DiscardUnusedFrame(
std::unique_ptr<RenderFrameHostImpl> render_frame_host) {
// TODO(carlosk): this code is very similar to what can be found in
// SwapOutOldFrame and we should see that these are unified at some point.
// If the SiteInstance for the pending RFH is being used by others, ensure
// that it is replaced by a RenderFrameProxyHost to allow other frames to
// communicate to this frame.
SiteInstanceImpl* site_instance = render_frame_host->GetSiteInstance();
RenderViewHostImpl* rvh = render_frame_host->render_view_host();
RenderFrameProxyHost* proxy = nullptr;
if (site_instance->HasSite() && site_instance->active_frame_count() > 1) {
// If a proxy already exists for the |site_instance|, just reuse it instead
// of creating a new one. There is no need to call SwapOut on the
// |render_frame_host|, as this method is only called to discard a pending
// or speculative RenderFrameHost, i.e. one that has never hosted an actual
// document.
proxy = GetRenderFrameProxyHost(site_instance);
if (!proxy)
proxy = CreateRenderFrameProxyHost(site_instance, rvh);
// Doing this is important in the case where the replacement proxy is created
// above, as the RenderViewHost will continue to exist and should be
// considered swapped out if it is ever reused. When there's no replacement
// proxy, this doesn't really matter, as the RenderViewHost will be destroyed
// shortly, since |render_frame_host| is its last active frame and will be
// deleted below. See
if (frame_tree_node_->IsMainFrame()) {
// If a new RenderFrameProxyHost was created above, or if the old proxy isn't
// live, create the RenderFrameProxy in the renderer, so that other frames
// can still communicate with this frame. See
if (proxy && !proxy->is_render_frame_proxy_live())
bool RenderFrameHostManager::DeleteFromPendingList(
RenderFrameHostImpl* render_frame_host) {
for (auto iter = pending_delete_hosts_.begin();
iter != pending_delete_hosts_.end(); iter++) {
if (iter->get() == render_frame_host) {
return true;
return false;
void RenderFrameHostManager::RestoreFromBackForwardCache(
std::unique_ptr<RenderFrameHostImpl> rfh) {
// Matched in CommitPending().
// speculative_render_frame_host_ will be committed during
// CommitPendingIfNecessary.
speculative_render_frame_host_ = std::move(rfh);
void RenderFrameHostManager::UnfreezeCurrentFrameHost() {
void RenderFrameHostManager::EvictFromBackForwardCache(
RenderFrameHostImpl* rfh) {
// TODO(hajimehoshi): Add a direct getter of BackForwardCache to
// RenderFrameHostDelegate.
BackForwardCache& back_forward_cache =
void RenderFrameHostManager::ResetProxyHosts() {
for (const auto& pair : proxy_hosts_) {
void RenderFrameHostManager::ClearRFHsPendingShutdown() {
void RenderFrameHostManager::ClearWebUIInstances() {
if (speculative_render_frame_host_)
void RenderFrameHostManager::DidCreateNavigationRequest(
NavigationRequest* request) {
if (request->is_served_from_back_forward_cache()) {
// Since the frame from the back-forward cache is being committed to the
// SiteInstance we already have, it is treated as current.
} else {
RenderFrameHostImpl* dest_rfh = GetFrameHostForNavigation(*request);
dest_rfh == render_frame_host_.get()
? NavigationRequest::AssociatedSiteInstanceType::CURRENT
: NavigationRequest::AssociatedSiteInstanceType::SPECULATIVE);
RenderFrameHostImpl* RenderFrameHostManager::GetFrameHostForNavigation(
const NavigationRequest& request) {
<< "Don't call this method for JavaScript URLs as those create a "
"temporary NavigationRequest and we don't want to reset an ongoing "
"navigation's speculative RFH.";
// A frame that's pending deletion should never be navigated. If this happens,
// log a DumpWithoutCrashing to understand the root cause.
// See and
if (!current_frame_host()->is_active()) {
NOTREACHED() << "Navigation in an inactive frame";
DEBUG_ALIAS_FOR_GURL(url, request.common_params().url);
// The appropriate RenderFrameHost to commit the navigation.
RenderFrameHostImpl* navigation_rfh = nullptr;
// First compute the SiteInstance to use for the navigation.
SiteInstance* current_site_instance = render_frame_host_->GetSiteInstance();
scoped_refptr<SiteInstance> dest_site_instance =
// The SiteInstance determines whether to switch RenderFrameHost or not.
bool use_current_rfh = current_site_instance == dest_site_instance;
// A crashed RenderFrameHost is never reused, but replaced by a new one
// immediately.
if (render_frame_host_->render_process_has_died())
use_current_rfh = false;
bool notify_webui_of_rf_creation = false;
if (use_current_rfh) {
// GetFrameHostForNavigation will be called more than once during a
// navigation (currently twice, on request and when it's about to commit in
// the renderer). In the follow up calls an existing pending WebUI should
// not be recreated if the URL didn't change. So instead of calling
// CleanUpNavigation just discard the speculative RenderFrameHost if one
// exists.
if (speculative_render_frame_host_) {
// If the speculative RenderFrameHost is trying to commit a navigation,
// inform the NavigationController that the load of the corresponding
// NavigationEntry stopped if needed. This is the case if the new
// navigation was started from BeginNavigation. If the navigation was
// started through the NavigationController, the NavigationController has
// already updated its state properly, and doesn't need to be notified.
// Note: We query all NavigationEntry IDs fom the RenderFrameHost, however
// at most one call to DiscardPendingEntryIfNeeded will succeed. Since we
// don't know which of the entries is the pending one, we have to try them
// all.
// TODO(clamy): Clean this up.
if (request.from_begin_navigation()) {
std::set<int> ids = speculative_render_frame_host_
for (int id : ids)
// Short-term solution: avoid creating a WebUI for subframes because
// non-PlzNavigate code path doesn't do it and some WebUI pages don't
// support it.
// TODO( Make WebUI objects always be per-frame instead.
if (frame_tree_node_->IsMainFrame()) {
navigation_rfh = render_frame_host_.get();
} else {
// If the current RenderFrameHost cannot be used a speculative one is
// created with the SiteInstance for the current URL. If a speculative
// RenderFrameHost already exists we try as much as possible to reuse it and
// its associated WebUI.
// Check for cases that a speculative RenderFrameHost cannot be used and
// create a new one if needed.
if (!speculative_render_frame_host_ ||
speculative_render_frame_host_->GetSiteInstance() !=
dest_site_instance.get() ||
speculative_render_frame_host_->render_process_has_died()) {
// If there is a speculative RenderFrameHost trying to commit a
// navigation, inform the NavigationController that the load of the
// corresponding NavigationEntry stopped if needed. This is the case if
// the new navigation was started from BeginNavigation. If the navigation
// was started through the NavigationController, the NavigationController
// has already updated its state properly, and doesn't need to be
// notified.
// Note: We query all NavigationEntry IDs fom the RenderFrameHost, however
// at most one call to DiscardPendingEntryIfNeeded will succeed. Since we
// don't know which of the entries is the pending one, we have to try them
// all.
// TODO(clamy): Clean this up.
if (request.from_begin_navigation() && speculative_render_frame_host_) {
std::set<int> ids = speculative_render_frame_host_
for (int id : ids)
// If a previous speculative RenderFrameHost didn't exist or if its
// SiteInstance differs from the one for the current URL, a new one needs
// to be created.
bool success = CreateSpeculativeRenderFrameHost(current_site_instance,
// Short-term solution: avoid creating a WebUI for subframes because
// non-PlzNavigate code path doesn't do it and some WebUI pages don't
// support it.
// TODO( Make WebUI objects always be per-frame instead.
if (frame_tree_node_->IsMainFrame()) {
bool changed_web_ui = speculative_render_frame_host_->UpdatePendingWebUI(
request.common_params().url, request.bindings());
DCHECK_EQ(GetNavigatingWebUI(), speculative_render_frame_host_->web_ui());
notify_webui_of_rf_creation =
changed_web_ui && speculative_render_frame_host_->web_ui();
navigation_rfh = speculative_render_frame_host_.get();
// Ensure that if the current RenderFrameHost is crashed, the following code
// path will always be used.
DCHECK(!render_frame_host_->render_process_has_died() ||
// Check if our current RFH is live.
if (!render_frame_host_->IsRenderFrameLive()) {
// The current RFH is not live. There's no reason to sit around with a
// sad tab or a newly created RFH while we wait for the navigation to
// complete. Just switch to the speculative RFH now and go back to normal.
// (Note that we don't care about on{before}unload handlers if the current
// RFH isn't live.)
// If the corresponding RenderFrame is currently associated with a proxy,
// send a SwapIn message to ensure that the RenderFrame swaps into the
// frame tree and replaces that proxy on the renderer side. Normally
// this happens at navigation commit time, but in this case this must be
// done earlier to keep browser and renderer state in sync. This is
// important to do before CommitPending(), which destroys the
// corresponding proxy. See
if (GetRenderFrameProxyHost(dest_site_instance.get())) {
new FrameMsg_SwapIn(navigation_rfh->GetRoutingID()));
// Notify the WebUI about the new RenderFrame if needed (the newly
// created WebUI has just been committed by CommitPending, so
// GetNavigatingWebUI() below will return false).
if (notify_webui_of_rf_creation && render_frame_host_->web_ui()) {
notify_webui_of_rf_creation = false;
DCHECK(navigation_rfh &&
(navigation_rfh == render_frame_host_.get() ||
navigation_rfh == speculative_render_frame_host_.get()));
// If the RenderFrame that needs to navigate is not live (its process was just
// created), initialize it.
if (!navigation_rfh->IsRenderFrameLive()) {
if (!ReinitializeRenderFrame(navigation_rfh))
return nullptr;
notify_webui_of_rf_creation = true;
if (navigation_rfh == render_frame_host_.get()) {
// TODO(nasko): This is a very ugly hack. The Chrome extensions process
// manager still uses NotificationService and expects to see a
// RenderViewHost changed notification after WebContents and
// RenderFrameHostManager are completely initialized. This should be
// removed once the process manager moves away from NotificationService.
// See
if (frame_tree_node_->IsMainFrame()) {
nullptr, render_frame_host_.get());
// If a WebUI was created in a speculative RenderFrameHost or a new
// RenderFrame was created then the WebUI never interacted with the
// RenderFrame or its RenderView. Notify using RenderFrameCreated.
// Short-term solution: avoid creating a WebUI for subframes because
// non-PlzNavigate code path doesn't do it and some WebUI pages don't
// support it.
// TODO( Make WebUI objects always be per-frame instead.
if (notify_webui_of_rf_creation && GetNavigatingWebUI() &&
frame_tree_node_->IsMainFrame()) {
// If this function picked an incompatible process for the URL, capture a
// crash dump to diagnose why it is occurring.
// TODO(creis): Remove this check after we've gathered enough information to
// debug issues with browser-side security checks.
auto* policy = ChildProcessSecurityPolicyImpl::GetInstance();
const GURL& lock_url = navigation_rfh->GetSiteInstance()->lock_url();
if (lock_url != GURL(kUnreachableWebDataURL) &&
request.common_params().url.IsStandard() &&
request.common_params().url) &&
!request.IsForMhtmlSubframe()) {
frame_tree_node_->IsMainFrame() ? "true" : "false");
use_current_rfh ? "true" : "false");
NOTREACHED() << "Picked an incompatible process for URL: " << lock_url
<< " lock vs " << request.common_params().url.GetOrigin();
return navigation_rfh;
void RenderFrameHostManager::CleanUpNavigation() {
if (speculative_render_frame_host_) {
bool was_loading = speculative_render_frame_host_->is_loading();
if (was_loading)
RenderFrameHostManager::UnsetSpeculativeRenderFrameHost() {
? FrameDeleteIntention::kNotMainFrame
: FrameDeleteIntention::kSpeculativeMainFrameForNavigationCancelled);
return std::move(speculative_render_frame_host_);
void RenderFrameHostManager::OnDidStartLoading() {
for (const auto& pair : proxy_hosts_) {
new FrameMsg_DidStartLoading(pair.second->GetRoutingID()));
void RenderFrameHostManager::OnDidStopLoading() {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_DidStopLoading(pair.second->GetRoutingID()));
void RenderFrameHostManager::OnDidUpdateName(const std::string& name,
const std::string& unique_name) {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_DidUpdateName(pair.second->GetRoutingID(),
name, unique_name));
void RenderFrameHostManager::OnDidAddContentSecurityPolicies(
const std::vector<ContentSecurityPolicyHeader>& headers) {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_AddContentSecurityPolicies(
pair.second->GetRoutingID(), headers));
void RenderFrameHostManager::OnDidResetContentSecurityPolicy() {
for (const auto& pair : proxy_hosts_) {
new FrameMsg_ResetContentSecurityPolicy(pair.second->GetRoutingID()));
void RenderFrameHostManager::OnEnforceInsecureRequestPolicy(
blink::WebInsecureRequestPolicy policy) {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_EnforceInsecureRequestPolicy(
pair.second->GetRoutingID(), policy));
void RenderFrameHostManager::OnEnforceInsecureNavigationsSet(
const std::vector<uint32_t>& insecure_navigations_set) {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_EnforceInsecureNavigationsSet(
pair.second->GetRoutingID(), insecure_navigations_set));
void RenderFrameHostManager::OnDidChangeCollapsedState(bool collapsed) {
SiteInstance* parent_site_instance =
// There will be no proxy to represent the pending or speculative RFHs in the
// parent's SiteInstance until the navigation is committed, but the old RFH is
// not swapped out before that happens either, so we can talk to the
// FrameOwner in the parent via the child's current RenderFrame at any time.
if (current_frame_host()->GetSiteInstance() == parent_site_instance) {
new FrameMsg_Collapse(current_frame_host()->GetRoutingID(), collapsed));
} else {
RenderFrameProxyHost* proxy_to_parent =
new FrameMsg_Collapse(proxy_to_parent->GetRoutingID(), collapsed));
void RenderFrameHostManager::OnDidUpdateFrameOwnerProperties(
const FrameOwnerProperties& properties) {
// FrameOwnerProperties exist only for frames that have a parent.
SiteInstance* parent_instance =
// Notify the RenderFrame if it lives in a different process from its parent.
if (render_frame_host_->GetSiteInstance() != parent_instance) {
render_frame_host_->Send(new FrameMsg_SetFrameOwnerProperties(
render_frame_host_->GetRoutingID(), properties));
// Notify this frame's proxies if they live in a different process from its
// parent. This is only currently needed for the allowFullscreen property,
// since that can be queried on RemoteFrame ancestors.
// TODO(alexmos): It would be sufficient to only send this update to proxies
// in the current FrameTree.
for (const auto& pair : proxy_hosts_) {
if (pair.second->GetSiteInstance() != parent_instance) {
pair.second->Send(new FrameMsg_SetFrameOwnerProperties(
pair.second->GetRoutingID(), properties));
void RenderFrameHostManager::OnDidUpdateOrigin(
const url::Origin& origin,
bool is_potentially_trustworthy_unique_origin) {
for (const auto& pair : proxy_hosts_) {
new FrameMsg_DidUpdateOrigin(pair.second->GetRoutingID(), origin,
BrowserContext* browser_context,
GURL dest_url,
SiteInstanceRelation relation_to_current)
: existing_site_instance(nullptr),
relation(relation_to_current) {}
void RenderFrameHostManager::RenderProcessGone(SiteInstanceImpl* instance) {
void RenderFrameHostManager::CancelPendingIfNecessary(
RenderFrameHostImpl* render_frame_host) {
if (render_frame_host == speculative_render_frame_host_.get()) {
// TODO(nasko, clamy): This should just clean up the speculative RFH
// without canceling the request. See
if (frame_tree_node_->navigation_request())
frame_tree_node_->ResetNavigationRequest(false, true);
void RenderFrameHostManager::UpdateUserActivationState(
blink::UserActivationUpdateType update_type) {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_UpdateUserActivationState(
pair.second->GetRoutingID(), update_type));
void RenderFrameHostManager::TransferUserActivationFrom(
RenderFrameHostImpl* source_rfh) {
for (const auto& pair : proxy_hosts_) {
SiteInstance* site_instance = pair.second->GetSiteInstance();
if (site_instance != source_rfh->GetSiteInstance()) {
int32_t source_routing_id =
pair.second->Send(new FrameMsg_TransferUserActivationFrom(
pair.second->GetRoutingID(), source_routing_id));
void RenderFrameHostManager::OnSetHasReceivedUserGestureBeforeNavigation(
bool value) {
for (const auto& pair : proxy_hosts_) {
pair.second->Send(new FrameMsg_SetHasReceivedUserGestureBeforeNavigation(
pair.second->GetRoutingID(), value));
void RenderFrameHostManager::ActiveFrameCountIsZero(
SiteInstanceImpl* site_instance) {
// |site_instance| no longer contains any active RenderFrameHosts, so we don't
// need to maintain a proxy there anymore.
RenderFrameProxyHost* proxy = GetRenderFrameProxyHost(site_instance);
RenderFrameProxyHost* RenderFrameHostManager::CreateRenderFrameProxyHost(
SiteInstance* site_instance,
scoped_refptr<RenderViewHostImpl> rvh) {
int site_instance_id = site_instance->GetId();
CHECK(proxy_hosts_.find(site_instance_id) == proxy_hosts_.end())
<< "A proxy already existed for this SiteInstance.";
RenderFrameProxyHost* proxy_host =
new RenderFrameProxyHost(site_instance, std::move(rvh), frame_tree_node_);
proxy_hosts_[site_instance_id] = base::WrapUnique(proxy_host);
return proxy_host;
void RenderFrameHostManager::DeleteRenderFrameProxyHost(
SiteInstance* site_instance) {
bool RenderFrameHostManager::ShouldTransitionCrossSite() {
// False in single-process mode, which does not support cross-process
// navigations or OOPIFs.
return !base::CommandLine::ForCurrentProcess()->HasSwitch(
bool RenderFrameHostManager::ShouldSwapBrowsingInstancesForNavigation(
const GURL& current_effective_url,
bool current_is_view_source_mode,
SiteInstance* new_site_instance,
const GURL& new_effective_url,
bool new_is_view_source_mode,
bool is_failure) const {
// A subframe must stay in the same BrowsingInstance as its parent.
// TODO(nasko): Ensure that SiteInstance swap is still triggered for subframes
// in the cases covered by the rest of the checks in this method.
if (!frame_tree_node_->IsMainFrame())
return false;
// If the navigation has resulted in an error page, do not swap
// BrowsingInstance and keep the error page in a related SiteInstance. If
// later a reload of this navigation is successful, it will correctly
// create a new BrowsingInstance.
if (is_failure && SiteIsolationPolicy::IsErrorPageIsolationEnabled(
frame_tree_node_->IsMainFrame())) {
return false;
// If new_entry already has a SiteInstance, assume it is correct. We only
// need to force a swap if it is in a different BrowsingInstance.
if (new_site_instance) {
return !new_site_instance->IsRelatedSiteInstance(
// Check for reasons to swap processes even if we are in a process model that
// doesn't usually swap (e.g., process-per-tab). Any time we return true,
// the new_entry will be rendered in a new SiteInstance AND BrowsingInstance.
BrowserContext* browser_context =
// Don't force a new BrowsingInstance for debug URLs that are handled in the
// renderer process, like javascript: or chrome://crash.
if (IsRendererDebugURL(new_effective_url))
return false;
// Transitions across BrowserContexts should always require a
// BrowsingInstance swap. For example, this can happen if an extension in a
// normal profile opens an incognito window with a web URL using
// TODO(alexmos): This check should've been enforced earlier in the
// navigation, in chrome::Navigate(). Verify this, and then convert this to
// a CHECK and remove the fallback.
if (browser_context !=
render_frame_host_->GetSiteInstance()->GetBrowserContext()) {
return true;
// For security, we should transition between processes when one is a Web UI
// page and one isn't, or if the WebUI types differ.
if (ChildProcessSecurityPolicyImpl::GetInstance()->HasWebUIBindings(
render_frame_host_->GetProcess()->GetID()) ||
browser_context, current_effective_url)) {
// If so, force a swap if destination is not an acceptable URL for Web UI.
// Here, data URLs are never allowed.
if (!WebUIControllerFactoryRegistry::GetInstance()->IsURLAcceptableForWebUI(
browser_context, new_effective_url)) {
return true;
// Force swap if the current WebUI type differs from the one for the
// destination.
if (WebUIControllerFactoryRegistry::GetInstance()->GetWebUIType(
browser_context, current_effective_url) !=
browser_context, new_effective_url)) {
return true;
} else {
// Force a swap if it's a Web UI URL.
if (WebUIControllerFactoryRegistry::GetInstance()->UseWebUIBindingsForURL(
browser_context, new_effective_url)) {
return true;
// Check with the content client as well. Important to pass
// current_effective_url here, which uses the SiteInstance's site if there is
// no current_entry.
if (GetContentClient()->browser()->ShouldSwapBrowsingInstancesForNavigation(
current_effective_url, new_effective_url)) {
return true;
// We can't switch a RenderView between view source and non-view source mode
// without screwing up the session history sometimes (when navigating between
// "view-source:" and "", Blink doesn't treat
// it as a new navigation). So require a BrowsingInstance switch.
if (current_is_view_source_mode != new_is_view_source_mode)
return true;
// If the target URL's origin was dynamically isolated, and the isolation
// wouldn't apply in the current BrowsingInstance, see if this navigation can
// safely swap to a new BrowsingInstance where this isolation would take
// effect. This helps protect sites that have just opted into process
// isolation, ensuring that the next navigation (e.g., a form submission
// after user has typed in a password) can utilize a dedicated process when
// possible (e.g., when there are no existing script references).
if (ShouldSwapBrowsingInstancesForDynamicIsolation(render_frame_host_.get(),
new_effective_url)) {
return true;
// Experimental mode to swap BrowsingInstances on most cross-site navigations
// when there are no other windows in the BrowsingInstance.
if (ShouldProactivelySwapBrowsingInstance(render_frame_host_.get(),
new_effective_url)) {
return true;
return false;
const GURL& dest_url,
SiteInstanceImpl* source_instance,
SiteInstanceImpl* dest_instance,
SiteInstanceImpl* candidate_instance,
ui::PageTransition transition,
bool is_failure,
bool dest_is_restore,
bool dest_is_view_source_mode,
bool was_server_redirect) {
// On renderer-initiated navigations, when the frame initiating the navigation
// and the frame being navigated differ, |source_instance| is set to the
// SiteInstance of the initiating frame. |dest_instance| is present on session
// history navigations. The two cannot be set simultaneously.
DCHECK(!source_instance || !dest_instance);
SiteInstance* current_instance = render_frame_host_->GetSiteInstance();
// We do not currently swap processes for navigations in webview tag guests.
if (current_instance->GetSiteURL().SchemeIs(kGuestScheme))
return current_instance;
// Determine if we need a new BrowsingInstance for this entry. If true, this
// implies that it will get a new SiteInstance (and likely process), and that
// other tabs in the current BrowsingInstance will be unable to script it.
// This is used for cases that require a process swap even in the
// process-per-tab model, such as WebUI pages.
// First determine the effective URL of the current RenderFrameHost. This is
// the last URL it successfully committed. If it has yet to commit a URL, this
// falls back to the Site URL of its SiteInstance.
// Note: the effective URL of the current RenderFrameHost may differ from the
// URL of the last committed NavigationEntry, which cannot be used to decide
// whether to use a new SiteInstance. This happens when navigating a subframe,
// or when a new RenderFrameHost has been swapped in at the beginning of a
// navigation to replace a crashed RenderFrameHost.
BrowserContext* browser_context =
const GURL& current_effective_url =
? SiteInstanceImpl::GetEffectiveURL(
browser_context, render_frame_host_->last_successful_url())
: render_frame_host_->GetSiteInstance()->GetSiteURL();
// Determine if the current RenderFrameHost is in view source mode.
// TODO(clamy): If the current_effective_url doesn't match the last committed
// NavigationEntry's URL, current_is_view_source_mode should not be computed
// using the NavigationEntry. This can happen when a tab crashed, and a new
// RenderFrameHost was swapped in at the beginning of the navigation. See
NavigationEntry* current_entry =
bool current_is_view_source_mode = current_entry ?
current_entry->IsViewSourceMode() : dest_is_view_source_mode;
bool force_swap = ShouldSwapBrowsingInstancesForNavigation(
current_effective_url, current_is_view_source_mode, dest_instance,
SiteInstanceImpl::GetEffectiveURL(browser_context, dest_url),
dest_is_view_source_mode, is_failure);
SiteInstanceDescriptor new_instance_descriptor =
if (ShouldTransitionCrossSite() || force_swap) {
new_instance_descriptor = DetermineSiteInstanceForURL(
dest_url, source_instance, current_instance, dest_instance, transition,
is_failure, dest_is_restore, dest_is_view_source_mode, force_swap,
scoped_refptr<SiteInstance> new_instance =
ConvertToSiteInstance(new_instance_descriptor, candidate_instance);
// If |force_swap| is true, we must use a different SiteInstance than the
// current one. If we didn't, we would have two RenderFrameHosts in the same
// SiteInstance and the same frame, breaking lookup of RenderFrameHosts by
// SiteInstance.
if (force_swap)
CHECK_NE(new_instance, current_instance);
if (new_instance == current_instance) {
// If we're navigating to the same site instance, we won't need to use the
// current spare RenderProcessHost.
// Double-check that the new SiteInstance is associated with the right
// BrowserContext.
DCHECK_EQ(new_instance->GetBrowserContext(), browser_context);
// If |new_instance| is a new SiteInstance for a subframe that requires a
// dedicated process, set its process reuse policy so that such subframes are
// consolidated into existing processes for that site.
SiteInstanceImpl* new_instance_impl =
if (!frame_tree_node_->IsMainFrame() &&
!new_instance_impl->IsDefaultSiteInstance() &&
!new_instance_impl->HasProcess() &&
new_instance_impl->RequiresDedicatedProcess()) {
// Also give the embedder a chance to override this decision. Certain
// frames have different enough workloads so that it's better to avoid
// placing a subframe into an existing process for better performance
// isolation. See
if (GetContentClient()->browser()->ShouldSubframesTryToReuseExistingProcess(
frame_tree_node_->frame_tree()->GetMainFrame())) {
return new_instance;
void RenderFrameHostManager::InitializeRenderFrameIfNecessary(
RenderFrameHostImpl* render_frame_host) {
// TODO(jam): this copies some logic inside GetFrameHostForNavigation, which
// also duplicates logic in Navigate. They should all use this method, but
// that involves slight reordering.
if (render_frame_host->IsRenderFrameLive())
if (!ReinitializeRenderFrame(render_frame_host))
if (render_frame_host != render_frame_host_.get())
// TODO(jam): uncomment this when the method is shared. Not adding the call
// now to make merge to 63 easier.
// EnsureRenderFrameHostPageFocusConsistent();
// TODO(nasko): This is a very ugly hack. The Chrome extensions process
// manager still uses NotificationService and expects to see a
// RenderViewHost changed notification after WebContents and
// RenderFrameHostManager are completely initialized. This should be
// removed once the process manager moves away from NotificationService.
// See
if (frame_tree_node_->IsMainFrame()) {
nullptr, render_frame_host_.get());
void RenderFrameHostManager::PrepareForInnerDelegateAttach(
RenderFrameHost::PrepareForInnerWebContentsAttachCallback callback) {
attach_inner_delegate_callback_ = std::move(callback);
DCHECK_EQ(attach_to_inner_delegate_state_, AttachToInnerDelegateState::NONE);
attach_to_inner_delegate_state_ = AttachToInnerDelegateState::PREPARE_FRAME;
if (current_frame_host()->ShouldDispatchBeforeUnload(
false /* check_subframes_only */)) {
// If there are beforeunload handlers in the frame or a nested subframe we
// should first dispatch the event and wait for the ACK form the renderer
// before proceeding with CreateNewFrameForInnerDelegateAttachIfNecessary.
RenderFrameHostImpl::BeforeUnloadType::INNER_DELEGATE_ATTACH, false);
const GURL& dest_url,
SiteInstance* source_instance,
SiteInstance* current_instance,
SiteInstance* dest_instance,
ui::PageTransition transition,
bool is_failure,
bool dest_is_restore,
bool dest_is_view_source_mode,
bool force_browsing_instance_swap,
bool was_server_redirect) {
SiteInstanceImpl* current_instance_impl =
NavigationControllerImpl& controller =
BrowserContext* browser_context = controller.GetBrowserContext();
// If the entry has an instance already we should use it, unless it is no
// longer suitable.
if (dest_instance) {
// When error page isolation is enabled, don't reuse |dest_instance| if it's
// an error page SiteInstance, but the navigation will no longer fail.
// Similarly, don't reuse |dest_instance| if it's not an error page
// SiteInstance but the navigation will fail and actually need an error page
// SiteInstance.
// Note: The later call to HasWrongProcessForURL does not have context about
// error page navigaions, so we cannot rely on it to return correct value
// when error pages are involved.
if (!SiteIsolationPolicy::IsErrorPageIsolationEnabled(
frame_tree_node_->IsMainFrame()) ||
((dest_instance->GetSiteURL() == GURL(kUnreachableWebDataURL)) ==
is_failure)) {
// TODO(nasko,creis): The check whether data: or about: URLs are allowed
// to commit in the current process should be in HasWrongProcessForURL.
// However, making this change has further implications and needs more
// investigation of what behavior changes. For now, use a conservative
// approach and explicitly check before calling HasWrongProcessForURL.
SiteInstanceImpl* dest_instance_impl =
if (IsDataOrAbout(dest_url) ||
!dest_instance_impl->HasWrongProcessForURL(dest_url)) {
// If we are forcing a swap, this should be in a different
// BrowsingInstance.
if (force_browsing_instance_swap) {
return SiteInstanceDescriptor(dest_instance);
// If a swap is required, we need to force the SiteInstance AND
// BrowsingInstance to be different ones, using CreateForURL.
if (force_browsing_instance_swap)
return SiteInstanceDescriptor(browser_context, dest_url,
// If error page navigations should be isolated, ensure a dedicated
// SiteInstance is used for them.
if (is_failure && SiteIsolationPolicy::IsErrorPageIsolationEnabled(
frame_tree_node_->IsMainFrame())) {
// Keep the error page in the same BrowsingInstance, such that in the case
// of transient network errors, a subsequent successful load of the same
// document will not result in broken scripting relationships between
// windows.
return SiteInstanceDescriptor(browser_context, GURL(kUnreachableWebDataURL),
if (!frame_tree_node_->IsMainFrame()) {
SiteInstance* parent_site_instance =
// TEMPORARY HACK: Don't create OOPIFs on the NTP. Remove this when the NTP
// supports OOPIFs or is otherwise omitted from site isolation policy.
// See
if (GetContentClient()->browser()->ShouldStayInParentProcessForNTP(
dest_url, parent_site_instance)) {
return SiteInstanceDescriptor(parent_site_instance);
// If we haven't used our SiteInstance (and thus RVH) yet, then we can use it
// for this entry. We won't commit the SiteInstance to this site until the
// navigation commits (in DidNavigate), unless the navigation entry was
// restored or it's a Web UI as described below.
if (!current_instance_impl->HasSite()) {
// If we've already created a SiteInstance for our destination, we don't
// want to use this unused SiteInstance; use the existing one. (We don't
// do this check if the current_instance has a site, because for now, we
// want to compare against the current URL and not the SiteInstance's site.
// In this case, there is no current URL, so comparing against the site is
// ok. See additional comments below.)
// Also, if the URL should use process-per-site mode and there is an
// existing process for the site, we should use it. We can call
// GetRelatedSiteInstance() for this, which will eagerly set the site and
// thus use the correct process.
bool use_process_per_site =
RenderProcessHost::ShouldUseProcessPerSite(browser_context, dest_url) &&
browser_context, current_instance_impl->GetIsolationContext(),
if (current_instance_impl->HasRelatedSiteInstance(dest_url) ||
use_process_per_site) {
return SiteInstanceDescriptor(browser_context, dest_url,
// For extensions, Web UI URLs (such as the new tab page), and apps we do
// not want to use the |current_instance_impl| if it has no site, since it
// will have a RenderProcessHost of PRIV_NORMAL. Create a new SiteInstance
// for this URL instead (with the correct process type).
if (current_instance_impl->HasWrongProcessForURL(dest_url))
return SiteInstanceDescriptor(browser_context, dest_url,
// View-source URLs must use a new SiteInstance and BrowsingInstance.
// TODO(nasko): This is the same condition as later in the function. This
// should be taken into account when refactoring this method as part of
if (dest_is_view_source_mode)
return SiteInstanceDescriptor(browser_context, dest_url,
// If we are navigating from a blank SiteInstance to a WebUI, make sure we
// create a new SiteInstance.
if (WebUIControllerFactoryRegistry::GetInstance()->UseWebUIForURL(
browser_context, dest_url)) {
return SiteInstanceDescriptor(browser_context, dest_url,
// Normally the "site" on the SiteInstance is set lazily when the load
// actually commits. This is to support better process sharing in case
// the site redirects to some other site: we want to use the destination
// site in the site instance.
// In the case of session restore, as it loads all the pages immediately
// we need to set the site first, otherwise after a restore none of the
// pages would share renderers in process-per-site.
// The embedder can request some urls never to be assigned to SiteInstance
// through the ShouldAssignSiteForURL() content client method, so that
// renderers created for particular chrome urls (e.g. the chrome-native://
// scheme) can be reused for subsequent navigations in the same WebContents.
// See
if (dest_is_restore && SiteInstanceImpl::ShouldAssignSiteForURL(dest_url))
return SiteInstanceDescriptor(current_instance_impl);
// Otherwise, only create a new SiteInstance for a cross-process navigation.
// TODO(creis): Once we intercept links and script-based navigations, we
// will be able to enforce that all entries in a SiteInstance actually have
// the same site, and it will be safe to compare the URL against the
// SiteInstance's site, as follows:
// const GURL& current_url = current_instance_impl->site();
// For now, though, we're in a hybrid model where you only switch
// SiteInstances if you type in a cross-site URL. This means we have to
// compare the entry's URL to the last committed entry's URL.
NavigationEntry* current_entry = controller.GetLastCommittedEntry();
if (delegate_->GetInterstitialForRenderManager()) {
// The interstitial is currently the last committed entry, but we want to
// compare against the last non-interstitial entry.
current_entry = controller.GetEntryAtOffset(-1);
// View-source URLs must use a new SiteInstance and BrowsingInstance.
// We don't need a swap when going from view-source to a debug URL like
// chrome://crash, however.
// TODO(creis): Refactor this method so this duplicated code isn't needed.
// See
if (current_entry &&
current_entry->IsViewSourceMode() != dest_is_view_source_mode &&
!IsRendererDebugURL(dest_url)) {
return SiteInstanceDescriptor(browser_context, dest_url,
// Use the source SiteInstance in case of data URLs, about:srcdoc pages and
// about:blank pages because the content is then controlled and/or scriptable
// by the source SiteInstance.
// One exception to this is when these URLs are
// reached via a server redirect. Normally, redirects to data: or about:
// URLs are disallowed as net::ERR_UNSAFE_REDIRECT, but extensions can still
// redirect arbitary requests to those URLs using webRequest or
// declarativeWebRequest API. For these cases, the content isn't controlled
// by the source SiteInstance, so it need not use it.
if (source_instance && IsDataOrAbout(dest_url) && !was_server_redirect)
return SiteInstanceDescriptor(source_instance);
// Use the current SiteInstance for same site navigations.
if (IsCurrentlySameSite(render_frame_host_.get(), dest_url))
return SiteInstanceDescriptor(render_frame_host_->GetSiteInstance());
// At this point, |dest_url| corresponds to a cross-site navigation. See if
// we can swap BrowsingInstances to avoid unneeded process sharing. This is
// done for certain main frame browser-initiated navigations. See
if (IsBrowsingInstanceSwapAllowedForPageTransition(transition, dest_url)) {
return SiteInstanceDescriptor(browser_context, dest_url,
// Shortcut some common cases for reusing an existing frame's SiteInstance.
// There are several reasons for this:
// - looking at the main frame and openers is required for TDI mode.
// - with hosted apps, this allows same-site, non-app subframes to be kept
// inside the hosted app process.
// - this avoids putting same-site iframes into different processes after
// navigations from isolated origins. This matters for some OAuth flows;
// see
// TODO(alexmos): Ideally, the right SiteInstance for these cases should be
// found later, as part of creating a new related SiteInstance from
// BrowsingInstance::GetSiteInstanceForURL(). However, the lookup there (1)
// does not properly deal with hosted apps (see,
// and (2) does not yet deal with cases where a SiteInstance is shared by
// several sites that don't require a dedicated process (see
if (!frame_tree_node_->IsMainFrame()) {
RenderFrameHostImpl* main_frame =
if (IsCurrentlySameSite(main_frame, dest_url))
return SiteInstanceDescriptor(main_frame->GetSiteInstance());
RenderFrameHostImpl* parent =
if (IsCurrentlySameSite(parent, dest_url))
return SiteInstanceDescriptor(parent->GetSiteInstance());
if (frame_tree_node_->opener()) {
RenderFrameHostImpl* opener_frame =
if (IsCurrentlySameSite(opener_frame, dest_url))
return SiteInstanceDescriptor(opener_frame->GetSiteInstance());
// Keep subframes in the parent's SiteInstance unless a dedicated process is
// required for either the parent or the subframe's destination URL. This
// isn't a strict invariant but rather a heuristic to avoid unnecessary
// OOPIFs; see
// TODO(alexmos): Remove this check after fixing
// Also if kProcessSharingWithStrictSiteInstances is enabled, don't lump the
// subframe into the same SiteInstance as the parent. These separate
// SiteInstances can get assigned to the same process later.
if (!base::FeatureList::IsEnabled(
features::kProcessSharingWithStrictSiteInstances)) {
if (!frame_tree_node_->IsMainFrame()) {
RenderFrameHostImpl* parent =
bool dest_url_requires_dedicated_process =
parent->GetSiteInstance()->GetIsolationContext(), dest_url);
if (!parent->GetSiteInstance()->RequiresDedicatedProcess() &&
!dest_url_requires_dedicated_process) {
return SiteInstanceDescriptor(parent->GetSiteInstance());
// Start the new renderer in a new SiteInstance, but in the current
// BrowsingInstance.
return SiteInstanceDescriptor(browser_context, dest_url,
bool RenderFrameHostManager::IsBrowsingInstanceSwapAllowedForPageTransition(
ui::PageTransition transition,
const GURL& dest_url) {
// Disallow BrowsingInstance swaps for subframes.
if (!frame_tree_node_->IsMainFrame())
return false;
// Skip data: and file: URLs, as some tests rely on browser-initiated
// navigations to those URLs to stay in the same process. Swapping
// BrowsingInstances for those URLs may not carry much benefit anyway, since
// they're likely less common.
// Note that such URLs are not considered same-site, but since their
// SiteInstance site URL is based only on scheme (e.g., all data URLs use a
// site URL of "data:"), a browser-initiated navigation from one such URL to
// another will still stay in the same SiteInstance, due to the matching site
// URL.
if (dest_url.SchemeIsFile() || dest_url.SchemeIs(url::kDataScheme))
return false;
// Allow page transitions corresponding to certain browser-initiated
// navigations: typing in the URL, using a bookmark, or using search.
switch (ui::PageTransitionStripQualifier(transition)) {
return true;
// TODO(alexmos): PAGE_TRANSITION_AUTO_TOPLEVEL is not included due to a
// bug that would cause unneeded BrowsingInstance swaps for DevTools,
// Once that bug is fixed, consider adding this
// transition here.
return false;
bool RenderFrameHostManager::IsRendererTransferNeededForNavigation(
RenderFrameHostImpl* rfh,
const GURL& dest_url) {
// Always attempt a process transfer if the SiteInstance has a process that's
// unsuitable for |dest_url|. For example, this might happen when reloading
// a URL for which a hosted app was just installed or uninstalled.
// This might also happen for a siteless SiteInstance which may have a
// process that's unsuitable for |dest_url|. For example, another navigation
// could share that process when over process limit and lock it to a
// different site before this SiteInstance sets its site. See
if (rfh->GetSiteInstance()->HasWrongProcessForURL(dest_url))
return true;
// A transfer is not needed if the current SiteInstance doesn't yet have a
// site. For example, this happens when tests use NavigateToURL or when
// navigating a blank window in some cases.
if (!rfh->GetSiteInstance()->HasSite())
return false;
// We do not currently swap processes for navigations in webview tag guests.
if (rfh->GetSiteInstance()->GetSiteURL().SchemeIs(kGuestScheme))
return false;
// Attempt a transfer if |dest_url|'s origin was dynamically isolated, and
// this navigation is eligible to perform a BrowsingInstance swap to ensure
// that |dest_url| is placed into a dedicated process. This is important to
// check before IsCurrentlySameSite() below, since in this case we might swap
// BrowsingInstances even for same-site navigations.
if (ShouldSwapBrowsingInstancesForDynamicIsolation(rfh, dest_url))
return true;
// Experimental mode to swap BrowsingInstances on most cross-site navigations
// when there are no other windows in the BrowsingInstance.
if (ShouldProactivelySwapBrowsingInstance(rfh, dest_url))
return true;
// TODO(nasko, nick): These following --site-per-process checks are
// overly simplistic. Update them to match all the cases
// considered by DetermineSiteInstanceForURL.
if (IsCurrentlySameSite(rfh, dest_url)) {
// The same site, no transition needed for security purposes, and we must
// keep the same SiteInstance for correctness of synchronous scripting.
return false;
// Attempting a transfer with kProcessSharingWithStrictSiteInstances allows
// us to "swap" from the renderer's perspective and create the full OOPIF
// plumbing, even if this subframe is eventually assigned to the same process
// as its cross-site parent.
if (base::FeatureList::IsEnabled(
return true;
// The sites differ. If either one requires a dedicated process,
// then a transfer is needed.
if (rfh->GetSiteInstance()->RequiresDedicatedProcess() ||
rfh->GetSiteInstance()->GetIsolationContext(), dest_url)) {
return true;
// If the destination URL is not same-site with current RenderFrameHost and
// doesn't require a dedicated process (see above), but it is same-site with
// the opener RenderFrameHost, attempt a transfer so that the destination URL
// can go back to the opener SiteInstance. This avoids breaking scripting in
// some cases when only a subset of sites is isolated
// (
// TODO(alexmos): This is a temporary workaround and should be removed after
// fixing
FrameTreeNode* opener = frame_tree_node_->opener();
if (opener && IsCurrentlySameSite(opener->current_frame_host(), dest_url) &&
opener->current_frame_host()->GetSiteInstance() != rfh->GetSiteInstance())
return true;
return false;
scoped_refptr<SiteInstance> RenderFrameHostManager::ConvertToSiteInstance(
const SiteInstanceDescriptor& descriptor,
SiteInstanceImpl* candidate_instance) {
SiteInstanceImpl* current_instance = render_frame_host_->GetSiteInstance();
// Note: If the |candidate_instance| matches the descriptor, it will already
// be set to |descriptor.existing_site_instance|.
if (descriptor.existing_site_instance)
return descriptor.existing_site_instance;
// Note: If the |candidate_instance| matches the descriptor,
// GetRelatedSiteInstance will return it.
if (descriptor.relation == SiteInstanceRelation::RELATED)
return current_instance->GetRelatedSiteInstance(descriptor.dest_url);
// At this point we know an unrelated site instance must be returned. First
// check if the candidate matches.
if (candidate_instance &&
!current_instance->IsRelatedSiteInstance(candidate_instance) &&
candidate_instance->DoesSiteForURLMatch(descriptor.dest_url)) {
return candidate_instance;
// Otherwise return a newly created one.
return SiteInstance::CreateForURL(
bool RenderFrameHostManager::IsCurrentlySameSite(RenderFrameHostImpl* candidate,
const GURL& dest_url) {
BrowserContext* browser_context =
// Ask embedder whether effective URLs should be used when determining if
// |dest_url| should end up in |candidate|'s SiteInstance.
// This is used to keep same-site scripting working for hosted apps.
bool should_compare_effective_urls =
candidate->GetSiteInstance()->IsDefaultSiteInstance() ||
browser_context, candidate->GetSiteInstance(),
candidate->GetSiteInstance()->original_url(), dest_url);
bool src_has_effective_url =
!candidate->GetSiteInstance()->IsDefaultSiteInstance() &&
browser_context, candidate->GetSiteInstance()->original_url());
bool dest_has_effective_url =
SiteInstanceImpl::HasEffectiveURL(browser_context, dest_url);
// If the process type is incorrect, reject the candidate even if |dest_url|
// is same-site. (The URL may have been installed as an app since
// the last time we visited it.)
// This check must be skipped to keep same-site subframe navigations from a
// hosted app to non-hosted app, and vice versa, in the same process.
// Otherwise, this would return false due to a process privilege level
// mismatch.
bool should_check_for_wrong_process =
should_compare_effective_urls ||
(!src_has_effective_url && !dest_has_effective_url);
if (should_check_for_wrong_process &&
candidate->GetSiteInstance()->HasWrongProcessForURL(dest_url)) {
return false;
// If we don't have a last successful URL, we can't trust the origin or URL
// stored on the frame, so we fall back to the SiteInstance URL. This case
// matters for newly created frames which haven't committed a navigation yet,
// as well as for net errors. Note that we use the SiteInstance's
// original_url() and not the site URL, so that we can do this comparison
// without the effective URL resolution if needed.
if (candidate->last_successful_url().is_empty()) {
return candidate->GetSiteInstance()->IsOriginalUrlSameSite(
dest_url, should_compare_effective_urls);
// In the common case, we use the RenderFrameHost's last successful URL. Thus,
// we compare against the last successful commit when deciding whether to swap
// this time.
if (SiteInstanceImpl::IsSameWebSite(
candidate->last_successful_url(), dest_url,
should_compare_effective_urls)) {
return true;
// It is possible that last_successful_url() was a nonstandard scheme (for
// example, "about:blank"). If so, examine the replicated origin to determine
// the site.
if (!candidate->GetLastCommittedOrigin().opaque() &&
GURL(candidate->GetLastCommittedOrigin().Serialize()), dest_url,
should_compare_effective_urls)) {
return true;
// If the last successful URL was "about:blank" with a unique origin (which
// implies that it was a browser-initiated navigation to "about:blank"), none
// of the cases above apply, but we should still allow a scenario like
// -> about:blank -> to be treated as same-site, as some
// tests rely on that behavior. To accomplish this, compare |dest_url|
// against the site URL.
if (candidate->last_successful_url().IsAboutBlank() &&
candidate->GetLastCommittedOrigin().opaque() &&
dest_url, should_compare_effective_urls)) {
return true;
// Not same-site.
return false;
void RenderFrameHostManager::CreateProxiesForNewRenderFrameHost(
SiteInstance* old_instance,
SiteInstance* new_instance) {
// Only create opener proxies if they are in the same BrowsingInstance.
if (new_instance->IsRelatedSiteInstance(old_instance)) {
CreateOpenerProxies(new_instance, frame_tree_node_);
} else {
// Ensure that the frame tree has RenderFrameProxyHosts for the
// new SiteInstance in all necessary nodes. We do this for all frames in
// the tree, whether they are in the same BrowsingInstance or not. If
// |new_instance| is in the same BrowsingInstance as |old_instance|, this
// will be done as part of CreateOpenerProxies above; otherwise, we do this
// here. We will still check whether two frames are in the same
// BrowsingInstance before we allow them to interact (e.g., postMessage).
frame_tree_node_, new_instance);
void RenderFrameHostManager::CreateProxiesForNewNamedFrame() {
// If this is a top-level frame, create proxies for this node in the
// SiteInstances of its opener's ancestors, which are allowed to discover
// this frame by name (see and part 4 of
// given-a-browsing-context-name).
FrameTreeNode* opener = frame_tree_node_->opener();
if (!opener || !frame_tree_node_->IsMainFrame())
SiteInstance* current_instance = render_frame_host_->GetSiteInstance();
// Start from opener's parent. There's no need to create a proxy in the
// opener's SiteInstance, since new windows are always first opened in the
// same SiteInstance as their opener, and if the new window navigates
// cross-site, that proxy would be created as part of swapping out.
for (FrameTreeNode* ancestor = opener->parent(); ancestor;
ancestor = ancestor->parent()) {
RenderFrameHostImpl* ancestor_rfh = ancestor->current_frame_host();
if (ancestor_rfh->GetSiteInstance() != current_instance)
SiteInstance* site_instance,
int32_t view_routing_id,
int32_t frame_routing_id,
int32_t widget_routing_id,
bool renderer_initiated_creation) {
if (frame_routing_id == MSG_ROUTING_NONE)
frame_routing_id = site_instance->GetProcess()->GetNextRoutingID();
// Create a RVH for main frames, or find the existing one for subframes.
FrameTree* frame_tree = frame_tree_node_->frame_tree();
scoped_refptr<RenderViewHostImpl> render_view_host;
if (frame_tree_node_->IsMainFrame()) {
render_view_host = frame_tree->CreateRenderViewHost(
site_instance, view_routing_id, frame_routing_id, widget_routing_id,
// TODO(avi): It's a bit bizarre that this logic lives here instead of in
// CreateRenderFrame(). It turns out that FrameTree::CreateRenderViewHost
// doesn't /always/ create a new RenderViewHost. It first tries to find an
// already existing one to reuse by a SiteInstance lookup. If it finds one,
// then the supplied routing IDs are completely ignored.
// CreateRenderFrame() could do this lookup too, but it seems redundant to
// do this lookup in two places. This is a good yak shave to clean up, or,
// if just ignored, should be an easy cleanup once RenderViewHostImpl has-a
// RenderWidgetHostImpl.
if (view_routing_id == MSG_ROUTING_NONE) {
widget_routing_id = render_view_host->GetWidget()->GetRoutingID();
} else {
DCHECK_NE(view_routing_id, widget_routing_id);
DCHECK_EQ(view_routing_id, render_view_host->GetRoutingID());
} else {
render_view_host = frame_tree->GetRenderViewHost(site_instance);
return RenderFrameHostFactory::Create(
site_instance, render_view_host, frame_tree->render_frame_delegate(),
frame_tree, frame_tree_node_, frame_routing_id, widget_routing_id,
bool RenderFrameHostManager::CreateSpeculativeRenderFrameHost(
SiteInstance* old_instance,
SiteInstance* new_instance) {
// We are creating a speculative RFH here. We should never create it in the
// same SiteInstance as our current RFH.
// This DCHECK is going to be fully removed as part of RenderDocument [1].
// Right now, the only case where a speculative RFH is created for a same-site
// navigation is when the old RenderFramehost has crashed.
// [1]
DCHECK(old_instance != new_instance ||
// The process for the new SiteInstance may (if we're sharing a process with
// another host that already initialized it) or may not (we have our own
// process or the existing process crashed) have been initialized. Calling
// Init multiple times will be ignored, so this is safe.
if (!new_instance->GetProcess()->Init())
return false;
CreateProxiesForNewRenderFrameHost(old_instance, new_instance);
speculative_render_frame_host_ = CreateRenderFrame(new_instance);
// If RenderViewHost was created along with the speculative RenderFrameHost,
// ensure that RenderViewCreated is fired for it. It is important to do this
// after speculative_render_frame_host_ is assigned, so that observers
// processing RenderViewCreated can find it via
// RenderViewHostImpl::GetMainFrame().
if (speculative_render_frame_host_) {
return !!speculative_render_frame_host_;
std::unique_ptr<RenderFrameHostImpl> RenderFrameHostManager::CreateRenderFrame(
SiteInstance* instance) {
// We are creating a pending or speculative RFH here. We should never create
// it in the same SiteInstance as our current RFH.
// This DCHECK is going to be fully removed as part of RenderDocument [1].
// Right now, the only case where a speculative RFH is created for a same-site
// navigation is when the old RenderFramehost has crashed.
// [1]
DCHECK(render_frame_host_->GetSiteInstance() != instance ||
// A RenderFrame in a different process from its parent RenderFrame
// requires a RenderWidget for input/layout/painting.
// TODO(ajwong): When RVH no longer owns a RWH, this logic should be
// simplified as the decision to create a RWH will be centralized here.
FrameTreeNode* parent = frame_tree_node_->parent();
int32_t widget_routing_id = MSG_ROUTING_NONE;
if (parent && parent->current_frame_host()->GetSiteInstance() != instance)
widget_routing_id = instance->GetProcess()->GetNextRoutingID();
std::unique_ptr<RenderFrameHostImpl> new_render_frame_host =
CreateRenderFrameHost(instance, MSG_ROUTING_NONE, MSG_ROUTING_NONE,
widget_routing_id, false);
DCHECK_EQ(new_render_frame_host->GetSiteInstance(), instance);
// Prevent the process from exiting while we're trying to navigate in it.
RenderViewHostImpl* render_view_host =
if (frame_tree_node_->IsMainFrame()) {
// Same-site navigation from a crashed RenderFrameHost is reinitializing
// the RenderViewHost with a new main RenderFrame with a new routing ID.
SiteInstance* current_site_instance = render_frame_host_->GetSiteInstance();
bool is_same_site = current_site_instance == instance;
if (is_same_site && render_frame_host_->render_process_has_died()) {
if (!InitRenderView(render_view_host, GetRenderFrameProxyHost(instance)))
return nullptr;
// If we are reusing the RenderViewHost and it doesn't already have a
// RenderWidgetHostView, we need to create one if this is the main frame.
if (!render_view_host->GetWidget()->GetView())
// And since we are reusing the RenderViewHost make sure it is hidden, like
// a new RenderViewHost would be, until navigation commits.
} else {
// RenderViewHost for |instance| might exist prior to calling
// CreateRenderFrame. In such a case, InitRenderView will not create the
// RenderFrame in the renderer process and it needs to be done
// explicitly.
if (!InitRenderFrame(new_render_frame_host.get()))
return nullptr;
return new_render_frame_host;
void RenderFrameHostManager::CreateRenderFrameProxy(SiteInstance* instance) {
// A RenderFrameProxyHost should never be created in the same SiteInstance as
// the current RFH.
CHECK_NE(instance, render_frame_host_->GetSiteInstance());
// If a proxy already exists and is alive, nothing needs to be done.
RenderFrameProxyHost* proxy = GetRenderFrameProxyHost(instance);
if (proxy && proxy->is_render_frame_proxy_live())
// At this point we know that we either have to 1) create a new
// RenderFrameProxyHost or 2) revive an existing, but no longer alive
// RenderFrameProxyHost.
if (!proxy) {
// The RenderViewHost creates the page level structure in Blink. The first
// object to depend on it is necessarily a main frame one.
CHECK(frame_tree_node_->frame_tree()->GetRenderViewHost(instance) ||
// Before creating a new RenderFrameProxyHost, ensure a RenderViewHost
// exists for |instance|, as it creates the page level structure in Blink.
scoped_refptr<RenderViewHostImpl> render_view_host =
proxy = CreateRenderFrameProxyHost(instance, std::move(render_view_host));
// Make sure that the RenderFrameProxy is present in the renderer.
if (frame_tree_node_->IsMainFrame() && proxy->GetRenderViewHost()) {
InitRenderView(proxy->GetRenderViewHost(), proxy);
} else {
void RenderFrameHostManager::CreateProxiesForChildFrame(FrameTreeNode* child) {
RenderFrameProxyHost* outer_delegate_proxy =
IsMainFrameForInnerDelegate() ? GetProxyToOuterDelegate() : nullptr;
for (const auto& pair : proxy_hosts_) {
// Do not create proxies for subframes in the outer delegate's process,
// since the outer delegate does not need to interact with them.
if (pair.second.get() == outer_delegate_proxy)
void RenderFrameHostManager::EnsureRenderViewInitialized(
RenderViewHostImpl* render_view_host,
SiteInstance* instance) {
if (render_view_host->IsRenderViewLive())
// If the proxy in |instance| doesn't exist, this RenderView is not swapped
// out and shouldn't be reinitialized here.
RenderFrameProxyHost* proxy = GetRenderFrameProxyHost(instance);
if (!proxy)
InitRenderView(render_view_host, proxy);
RenderFrameProxyHost* RenderFrameHostManager::CreateOuterDelegateProxy(
SiteInstance* outer_contents_site_instance) {
// We only get here when Delegate for this manager is an inner delegate.
return CreateRenderFrameProxyHost(outer_contents_site_instance, nullptr);
void RenderFrameHostManager::DeleteOuterDelegateProxy(
SiteInstance* outer_contents_site_instance) {
void RenderFrameHostManager::SwapOuterDelegateFrame(
RenderFrameHostImpl* render_frame_host,
RenderFrameProxyHost* proxy) {
// Swap the outer WebContents's frame with the proxy to inner WebContents.
// We are in the outer WebContents, and its FrameTree would never see
// a load start for any of its inner WebContents. Eventually, that also makes
// the FrameTree never see the matching load stop. Therefore, we always pass
// false to |is_loading| below.
// TODO(lazyboy): This |is_loading| behavior might not be what we want,
// investigate and fix.
DCHECK_EQ(render_frame_host->GetSiteInstance(), proxy->GetSiteInstance());
render_frame_host->Send(new UnfreezableFrameMsg_SwapOut(
render_frame_host->GetRoutingID(), proxy->GetRoutingID(),
false /* is_loading */,
void RenderFrameHostManager::SetRWHViewForInnerContents(
RenderWidgetHostView* child_rwhv) {
GetProxyToOuterDelegate()->SetChildRWHView(child_rwhv, nullptr);
bool RenderFrameHostManager::InitRenderView(
RenderViewHostImpl* render_view_host,
RenderFrameProxyHost* proxy) {
// Ensure the renderer process is initialized before creating the
// RenderView.
if (!render_view_host->GetProcess()->Init())
return false;
// We may have initialized this RenderViewHost for another RenderFrameHost.
if (render_view_host->IsRenderViewLive())
return true;
int opener_frame_routing_id =
bool created = delegate_->CreateRenderViewForRenderManager(
render_view_host, opener_frame_routing_id,
proxy ? proxy->GetRoutingID() : MSG_ROUTING_NONE,
if (created && proxy) {
// If this main frame proxy was created for a frame that hasn't yet
// finished loading, let the renderer know so it can also mark the proxy as
// loading. See
if (frame_tree_node_->IsLoading())
proxy->Send(new FrameMsg_DidStartLoading(proxy->GetRoutingID()));
return created;
const NavigationRequest& request) {
SiteInstance* current_site_instance = render_frame_host_->GetSiteInstance();
// All children of MHTML documents must be MHTML documents. They all live in
// the same process.
if (request.IsForMhtmlSubframe())
return base::WrapRefCounted(current_site_instance);
// Srcdoc documents are always in the same SiteInstance as their parent. They
// load their content from the "srcdoc" iframe attribute which lives in the
// parent's process.
RenderFrameHostImpl* parent = render_frame_host_->GetParent();
if (parent && request.common_params().url.IsAboutSrcdoc())
return base::WrapRefCounted(parent->GetSiteInstance());
// First, check if the navigation can switch SiteInstances. If not, the
// navigation should use the current SiteInstance.
bool no_renderer_swap_allowed = false;
bool should_swap_for_error_isolation = false;
bool was_server_redirect = request.navigation_handle() &&
// When error page isolation is enabled, each navigation that crosses
// from a success to failure and vice versa needs to do a process swap.
if (SiteIsolationPolicy::IsErrorPageIsolationEnabled(
frame_tree_node_->IsMainFrame())) {
should_swap_for_error_isolation =
(request.state() == NavigationRequest::FAILED) !=
(current_site_instance->GetSiteURL() == GURL(kUnreachableWebDataURL));
if (frame_tree_node_->IsMainFrame()) {
// Renderer-initiated main frame navigations that may require a
// SiteInstance swap are sent to the browser via the OpenURL IPC and are
// afterwards treated as browser-initiated navigations. NavigationRequests
// marked as renderer-initiated are created by receiving a BeginNavigation
// IPC, and will then proceed in the same renderer. In site-per-process
// mode, it is possible for renderer-intiated navigations to be allowed to
// go cross-process. Check it first.
bool can_renderer_initiate_transfer =
IsURLHandledByNetworkStack(request.common_params().url) &&
no_renderer_swap_allowed |=
request.from_begin_navigation() && !can_renderer_initiate_transfer;
} else {
// Subframe navigations will use the current renderer, unless specifically
// allowed to swap processes.
no_renderer_swap_allowed |= !CanSubframeSwapProcess(
request.common_params().url, request.source_site_instance(),
if (no_renderer_swap_allowed && !should_swap_for_error_isolation)
return scoped_refptr<SiteInstance>(current_site_instance);
// If the navigation can swap SiteInstances, compute the SiteInstance it
// should use.
// TODO(clamy): We should also consider as a candidate SiteInstance the
// speculative SiteInstance that was computed on redirects.
SiteInstanceImpl* candidate_site_instance =
? speculative_render_frame_host_->GetSiteInstance()
: nullptr;
scoped_refptr<SiteInstance> dest_site_instance = GetSiteInstanceForNavigation(
request.common_params().url, request.source_site_instance(),
request.dest_site_instance(), candidate_site_instance,
request.state() == NavigationRequest::FAILED,
request.restore_type() != RestoreType::NONE, request.is_view_source(),
return dest_site_instance;
bool RenderFrameHostManager::InitRenderFrame(
RenderFrameHostImpl* render_frame_host) {
if (render_frame_host->IsRenderFrameLive())
return true;
SiteInstance* site_instance = render_frame_host->GetSiteInstance();
int opener_routing_id = MSG_ROUTING_NONE;
if (frame_tree_node_->opener())
opener_routing_id = GetOpenerRoutingID(site_instance);
int parent_routing_id = MSG_ROUTING_NONE;
if (frame_tree_node_->parent()) {
parent_routing_id = frame_tree_node_->parent()
CHECK_NE(parent_routing_id, MSG_ROUTING_NONE);
// At this point, all RenderFrameProxies for sibling frames have already been
// created, including any proxies that come after this frame. To preserve
// correct order for indexed window access (e.g., window.frames[1]), pass the
// previous sibling frame so that this frame is correctly inserted into the
// frame tree on the renderer side.
int previous_sibling_routing_id = MSG_ROUTING_NONE;
FrameTreeNode* previous_sibling = frame_tree_node_->PreviousSibling();
if (previous_sibling) {
previous_sibling_routing_id =
CHECK_NE(previous_sibling_routing_id, MSG_ROUTING_NONE);
// Check whether there is an existing proxy for this frame in this
// SiteInstance. If there is, the new RenderFrame needs to be able to find
// the proxy it is replacing, so that it can fully initialize itself.
// NOTE: This is the only time that a RenderFrameProxyHost can be in the same
// SiteInstance as its RenderFrameHost. This is only the case until the
// RenderFrameHost commits, at which point it will replace and delete the
// RenderFrameProxyHost.
// TODO(arthursonzogni): Implement same-process RenderFrame swap. In this case
// |previous_routing_id| can represent not only a RenderFrameProxyHost, but
// can also represent a RenderFrameHost.
int previous_routing_id = MSG_ROUTING_NONE;
RenderFrameProxyHost* existing_proxy = GetRenderFrameProxyHost(site_instance);
if (existing_proxy) {
previous_routing_id = existing_proxy->GetRoutingID();
CHECK_NE(previous_routing_id, MSG_ROUTING_NONE);
if (!existing_proxy->is_render_frame_proxy_live())
return delegate_->CreateRenderFrameForRenderManager(
render_frame_host, previous_routing_id, opener_routing_id,
parent_routing_id, previous_sibling_routing_id);
bool RenderFrameHostManager::ReinitializeRenderFrame(
RenderFrameHostImpl* render_frame_host) {
// This should be used only when the RenderFrame is not live.
// Recreate the opener chain.
CreateOpenerProxies(render_frame_host->GetSiteInstance(), frame_tree_node_);
// Main frames need both the RenderView and RenderFrame reinitialized, so
// use InitRenderView. For cross-process subframes, InitRenderView won't
// recreate the RenderFrame, so use InitRenderFrame instead. Note that for
// subframe RenderFrameHosts, the swapped out RenderView in their
// SiteInstance will be recreated as part of CreateOpenerProxies above.
if (!frame_tree_node_->parent()) {
if (!InitRenderView(render_frame_host->render_view_host(), nullptr))
return false;
} else {
if (!InitRenderFrame(render_frame_host))
return false;
// When a subframe renderer dies, its RenderWidgetHostView is cleared in
// its CrossProcessFrameConnector, so we need to restore it now that it
// is re-initialized.
RenderFrameProxyHost* proxy_to_parent = GetProxyToParent();
if (proxy_to_parent) {
const gfx::Size* size = render_frame_host->frame_size()
? &*render_frame_host->frame_size()
: nullptr;
GetProxyToParent()->SetChildRWHView(render_frame_host->GetView(), size);
// The RenderWidgetHostView goes away with the render process. Initializing a
// RenderFrame means we'll be creating (or reusing,
// a RenderWidgetHostView. The new RenderWidgetHostView should take its
// visibility from the RenderWidgetHostImpl, but this call exists to handle
// cases where it did not during a same-process navigation.
// TODO(danakj): We now hide the widget unconditionally (treating main frame
// and child frames alike) and show in DidFinishNavigation() always, so this
// should be able to go away. Try to remove this.
if (render_frame_host == render_frame_host_.get())
return true;
int RenderFrameHostManager::GetRoutingIdForSiteInstance(
SiteInstance* site_instance) {
if (render_frame_host_->GetSiteInstance() == site_instance)
return render_frame_host_->GetRoutingID();
RenderFrameProxyHost* proxy = GetRenderFrameProxyHost(site_instance);
if (proxy)
return proxy->GetRoutingID();
void RenderFrameHostManager::CommitPendingWebUI() {
TRACE_EVENT1("navigation", "RenderFrameHostManager::CommitPendingWebUI",
"FrameTreeNode id", frame_tree_node_->frame_tree_node_id());
// First check whether we're going to want to focus the location bar after
// this commit. We do this now because the navigation hasn't formally
// committed yet, so if we've already cleared the pending WebUI the call chain
// this triggers won't be able to figure out what's going on.
bool will_focus_location_bar = delegate_->FocusLocationBarByDefault();
if (will_focus_location_bar)
void RenderFrameHostManager::CommitPending(
std::unique_ptr<RenderFrameHostImpl> pending_rfh) {
TRACE_EVENT1("navigation", "RenderFrameHostManager::CommitPending",
"FrameTreeNode id", frame_tree_node_->frame_tree_node_id());
#if defined(OS_MACOSX)
// The old RenderWidgetHostView will be hidden before the new
// RenderWidgetHostView takes its contents. Ensure that Cocoa sees this as
// a single transaction.
// TODO(ccameron): This can be removed when the RenderWidgetHostViewMac uses
// the same ui::Compositor as MacViews.
gfx::ScopedCocoaDisableScreenUpdates disabler;
#endif // defined(OS_MACOSX)
RenderWidgetHostView* old_view = render_frame_host_->GetView();
RenderWidgetHostView* new_view = pending_rfh->GetView();
bool is_main_frame = frame_tree_node_->IsMainFrame();
// First check whether we're going to want to focus the location bar after
// this commit. We do this now because the navigation hasn't formally
// committed yet, so if we've already cleared the pending WebUI the call chain
// this triggers won't be able to figure out what's going on. Note that
// subframe commits should not be allowed to steal focus from the main frame
// by focusing the location bar (see
bool will_focus_location_bar =
is_main_frame && delegate_->FocusLocationBarByDefault();
// Remember if the page was focused so we can focus the new renderer in
// that case.
bool focus_render_view =
!will_focus_location_bar && old_view && old_view->HasFocus();
// Remove the current frame and its descendants from the set of fullscreen
// frames immediately. They can stay in pending deletion for some time.
// Removing them when they are deleted is too late.
// This needs to be done before updating the frame tree structure, else it
// will have trouble removing the descendants.
->FullscreenStateChanged(current_frame_host(), false);
// If the removed frame was created by a script, then its history entry will
// never be reused - we can save some memory by removing the history entry.
// See also
// This is done in ~FrameTreeNode, but this is needed here as well. For
// instance if the user navigates from A(B) to C and B is deleted after C
// commits, then the last committed navigation entry wouldn't match anymore.
NavigationEntryImpl* navigation_entry = static_cast<NavigationEntryImpl*>(
if (navigation_entry) {
// Swap in the pending frame and make it active. Also ensure the FrameTree
// stays in sync.
std::unique_ptr<RenderFrameHostImpl> old_render_frame_host;
old_render_frame_host = SetRenderFrameHost(std::move(pending_rfh));
// For top-level frames, the RenderWidget{Host} will not be destroyed when the
// local frame is detached.
// To work around that, we hide it here. Truly this is to hit all the hide
// paths in the browser side, but has a side effect of also hiding the
// renderer side RenderWidget, even though it will get frozen anyway in the
// future. However freezing doesn't do all the things hiding does at this time
// so that's probably good.
// Note the RenderWidgetHostView can be missing if the process for the old
// RenderFrameHost crashed.
// TODO( This is only done for the main frame, as for sub
// frames the RenderWidget and its view will be destroyed when the frame is
// detached, but for the main frame it is not. This call to Hide() can go away
// when the main frame's RenderWidget is destroyed on frame detach. Note that
// calling this on a subframe that is not a local root would be incorrect as
// it would hide an ancestor local root's RenderWidget when that frame is not
// necessarily navigating. Removing this Hide() has previously been attempted
// without success in r426913 ( and r438516 (broke
// assumptions about RenderWidgetHosts not changing RenderWidgetHostViews over
// time).
// |old_view| and |new_view| can be the same when navigating same-site from a
// crashed RenderFrameHost. When RenderDocument will be implemented, this will
// happen for each same-site navigation.
if (is_main_frame && old_view && old_view != new_view) {
// Note that this hides the RenderWidget but does not hide the Page. If it
// did hide the Page then making a new RenderFrameHost on another call to
// here would need to make sure it showed the RenderView when the
// RenderWidget was created as visible.
// Make sure the size is up to date. (Fix for bug 1079768.)
if (will_focus_location_bar) {
} else if (focus_render_view && new_view) {
if (is_main_frame) {
} else {
// The current tab has page-level focus, so we need to propagate
// page-level focus to the subframe's renderer. Before doing that, also
// tell the new renderer what the focused frame is if that frame is not
// in its process, so that Blink's page-level focus logic won't try to
// reset frame focus to the main frame. See
FrameTreeNode* focused_frame =
if (focused_frame && !focused_frame->IsMainFrame() &&
focused_frame->current_frame_host()->GetSiteInstance() !=
render_frame_host_->GetSiteInstance()) {
render_frame_host_->GetSiteInstance(), true);
// Notify that we've swapped RenderFrameHosts. We do this before shutting down
// the RFH so that we can clean up RendererResources related to the RFH first.
old_render_frame_host.get(), render_frame_host_.get(), is_main_frame);
// Make the new view show the contents of old view until it has something
// useful to show.
if (is_main_frame && old_view && new_view && old_view != new_view)
RenderViewHostImpl* old_rvh = old_render_frame_host->render_view_host();
RenderViewHostImpl* new_rvh = render_frame_host_->render_view_host();
// The RenderViewHost keeps track of the main RenderFrameHost routing id.
// If this is committing a main frame navigation, update it and set the
// routing id in the RenderViewHost associated with the old RenderFrameHost
if (is_main_frame) {
// If the RenderViewHost is transitioning from swapped out to active state,
// it was reused, so dispatch a RenderViewReady event. For example, this is
// necessary to hide the sad tab if one is currently displayed. See
// Note that observers of RenderViewReady() will see the updated main frame
// routing ID, since PostRenderViewReady() posts a task.
// TODO(alexmos): Remove this and move RenderViewReady consumers to use
// the main frame's RenderFrameCreated instead.
if (!new_rvh->is_active())
if (old_rvh != new_rvh)
// Store the old_render_frame_host's current frame size so that it can be used
// to initialize the child RWHV.
base::Optional<gfx::Size> old_size = old_render_frame_host->frame_size();
// Swap out the old frame now that the new one is visible.
// This will swap it out and schedule it for deletion when the swap out ack
// arrives (or immediately if the process isn't live).
// Since the new RenderFrameHost is now committed, there must be no proxies
// for its SiteInstance. Delete any existing ones.
// If this is a subframe, it should have a CrossProcessFrameConnector
// created already. Use it to link the new RFH's view to the proxy that
// belongs to the parent frame's SiteInstance. If this navigation causes
// an out-of-process frame to return to the same process as its parent, the
// proxy would have been removed from proxy_hosts_ above.
// Note: We do this after swapping out the old RFH because that may create
// the proxy we're looking for.
RenderFrameProxyHost* proxy_to_parent = GetProxyToParent();
if (proxy_to_parent)
proxy_to_parent->SetChildRWHView(new_view, old_size ? &*old_size : nullptr);
if (render_frame_host_->is_local_root() && new_view) {
// RenderFrames are created with a hidden RenderWidgetHost. When navigation
// finishes, we show it if the delegate is shown.
if (!delegate_->IsHidden())
// The process will no longer try to exit, so we can decrement the count.
// If there's no RenderWidgetHostView on this frame's local root (or itself
// if it is a local root), then this RenderViewHost died while it was hidden.
// We ignored the RenderProcessGone call at the time, so we should send it now
// to make sure the sad tab shows up, etc.
if (!new_view) {
// After all is done, there must never be a proxy in the list which has the
// same SiteInstance as the current RenderFrameHost.
void RenderFrameHostManager::UpdatePendingWebUIOnCurrentFrameHost(
const GURL& dest_url,
int entry_bindings) {
bool pending_webui_changed =
render_frame_host_->UpdatePendingWebUI(dest_url, entry_bindings);
DCHECK_EQ(GetNavigatingWebUI(), render_frame_host_->pending_web_ui());
if (render_frame_host_->pending_web_ui() && pending_webui_changed &&
render_frame_host_->IsRenderFrameLive()) {
// If a pending WebUI exists in the current RenderFrameHost and it has been
// updated and the associated RenderFrame is alive, notify the WebUI about
// the RenderFrame.
// Note: If the RenderFrame is not alive at this point the notification
// will happen later, when the RenderFrame is created.
if (render_frame_host_->pending_web_ui() == render_frame_host_->web_ui()) {
// If the active WebUI is being reused it has already interacting with
// this RenderFrame and its RenderView in the past, so call
// RenderFrameReused.
} else {
// If this is a new WebUI it has never interacted with the existing
// RenderFrame so call RenderFrameCreated.
std::unique_ptr<RenderFrameHostImpl> RenderFrameHostManager::SetRenderFrameHost(
std::unique_ptr<RenderFrameHostImpl> render_frame_host) {
// Swap the two.
std::unique_ptr<RenderFrameHostImpl> old_render_frame_host =
render_frame_host_ = std::move(render_frame_host);
if (frame_tree_node_->IsMainFrame()) {
// Update the count of top-level frames using this SiteInstance. All
// subframes are in the same BrowsingInstance as the main frame, so we only
// count top-level ones. This makes the value easier for consumers to
// interpret.
if (render_frame_host_) {
if (old_render_frame_host) {
return old_render_frame_host;
RenderViewHostImpl* RenderFrameHostManager::GetSwappedOutRenderViewHost(
SiteInstance* instance) const {
RenderFrameProxyHost* proxy = GetRenderFrameProxyHost(instance);
if (proxy)
return proxy->GetRenderViewHost();
return nullptr;
RenderFrameProxyHost* RenderFrameHostManager::GetRenderFrameProxyHost(
SiteInstance* instance) const {
auto it = proxy_hosts_.find(instance->GetId());
if (it != proxy_hosts_.end())
return it->second.get();
return nullptr;
size_t RenderFrameHostManager::GetProxyCount() {
return proxy_hosts_.size();
void RenderFrameHostManager::CollectOpenerFrameTrees(
std::vector<FrameTree*>* opener_frame_trees,
std::unordered_set<FrameTreeNode*>* nodes_with_back_links) {
// Add the FrameTree of the given node's opener to the list of
// |opener_frame_trees| if it doesn't exist there already. |visited_index|
// indicates which FrameTrees in |opener_frame_trees| have already been
// visited (i.e., those at indices less than |visited_index|).
// |nodes_with_back_links| collects FrameTreeNodes with openers in FrameTrees
// that have already been visited (such as those with cycles).
size_t visited_index = 0;
while (visited_index < opener_frame_trees->size()) {
FrameTree* frame_tree = (*opener_frame_trees)[visited_index];
for (FrameTreeNode* node : frame_tree->Nodes()) {
if (!node->opener())
FrameTree* opener_tree = node->opener()->frame_tree();
const auto& existing_tree_it = std::find(
opener_frame_trees->begin(), opener_frame_trees->end(), opener_tree);
if (existing_tree_it == opener_frame_trees->end()) {
// This is a new opener tree that we will need to process.
} else {
// If this tree is already on our processing list *and* we have visited
// it,
// then this node's opener is a back link. This means the node will
// need
// special treatment to process its opener.
size_t position =
std::distance(opener_frame_trees->begin(), existing_tree_it);
if (position < visited_index)
void RenderFrameHostManager::CreateOpenerProxies(
SiteInstance* instance,
FrameTreeNode* skip_this_node) {
std::vector<FrameTree*> opener_frame_trees;
std::unordered_set<FrameTreeNode*> nodes_with_back_links;
CollectOpenerFrameTrees(&opener_frame_trees, &nodes_with_back_links);
// Create opener proxies for frame trees, processing furthest openers from
// this node first and this node last. In the common case without cycles,
// this will ensure that each tree's openers are created before the tree's
// nodes need to reference them.
for (FrameTree* tree : base::Reversed(opener_frame_trees)) {
instance, skip_this_node);